Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for enabling/disabling optional regions #31300

Closed
obeliskm opened this issue May 10, 2023 · 3 comments · Fixed by #35739
Closed

[Enhancement]: Add support for enabling/disabling optional regions #31300

obeliskm opened this issue May 10, 2023 · 3 comments · Fixed by #35739
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/account Issues and PRs that pertain to the account service.
Milestone

Comments

@obeliskm
Copy link

Description

AWS added four new API calls on Feb 13 2023:

GetRegionOptStatus
DisableRegion
ListRegions
EnableRegion

https://awsapichanges.info/archive/changes/0366a2-account.html

the Go SDK https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/account and CLI (v2.10.0) were updated a couple of days later to support enabling/disabling optional regions, it would be nice if the AWS provider also supported this..

Affected Resource(s) and/or Data Source(s)

  • aws_account_enable_region
  • data.aws_account_regions
  • data.aws_account_regionoptstatus # may not need to be exposed, could just be used by enable_region?

Potential Terraform Configuration

resource "aws_account_enable_region" "example" {
  account_id  = "111111111111"       # optional, defaults to current account
  region_name = "opt-in-region-name" # mandatory, eg "ap-southeast-4"
}

# There's some extra complexity because the account_id can only be supplied if you're in a Management account or delegated admin account for an Org - but presumably it's ok to just fail with an error from the underlying API call if a user tries to enable a region for another account when they're not in the correct management account.

data "aws_account_regions" "example" {
  account_id  = "111111111111"       # optional, defaults to current account
  region_opt_status_contains = [ ENABLED | ENABLING | DISABLING | DISABLED | ENABLED_BY_DEFAULT ]
}

Then ideally then we'd be able to use this to setup provider aliases for each region - something like

provider "aws" {
  for_each = data.aws_account_regions.example
  alias  = each.key
  region = each.key
}

but I'm aware that is outrageous levels of scope creep that likely is impossible, so I only mention it as an idea.

References

https://docs.aws.amazon.com/accounts/latest/reference/API_Operations.html

Would you like to implement a fix?

No

@obeliskm obeliskm added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 10, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/account Issues and PRs that pertain to the account service. label May 10, 2023
@obeliskm obeliskm changed the title [Enhancement]: [Enhancement]: Add support for enabling/disabling optional regions May 10, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 11, 2023
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 6, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/account Issues and PRs that pertain to the account service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants