Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: #30885 introduced a new perpetual diff #31136

Closed
k-brooks opened this issue May 3, 2023 · 9 comments · Fixed by #34356
Closed

[Bug]: #30885 introduced a new perpetual diff #31136

k-brooks opened this issue May 3, 2023 · 9 comments · Fixed by #34356
Labels
bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@k-brooks
Copy link

k-brooks commented May 3, 2023

Terraform Core Version

1.4.5

AWS Provider Version

4.65.0

Affected Resource(s)

aws_dms_replication_task

Expected Behavior

Specifying the EnableLogContext property in the replication task settings should not trigger a perpetual diff.

Actual Behavior

Specifying the EnableLogContext property in the replication task settings triggers a perpetual diff.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_dms_replication_task" "example" {
      id                        = "example"
      replication_task_settings = jsonencode(
           {
              Logging  = {
                  EnableLogContext = false
                }
            }
        )
    }

Steps to Reproduce

  1. Apply
  2. Plan - see diff

Debug Output

No response

Panic Output

No response

Important Factoids

Introduced by #30885

References

#19883

Would you like to implement a fix?

None

@k-brooks k-brooks added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels May 3, 2023
@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 3, 2023
@johnathan99j
Copy link

I'm getting this on provider 4.67.0 as well

@gfysaris
Copy link

I have the same issue with
Terraform v1.2.2 on windows_amd64

  • provider registry.terraform.io/hashicorp/aws v5.11.0

@jcourteauupgrade
Copy link

jcourteauupgrade commented Sep 15, 2023

This seems tied to the version of the DMS replication instance for the task. I don't have any issues when it's 3.5.1, but I do on 3.4.7. It looks like EnableLogContext requires > 3.5.0 (docs; look for AWS DMS Context logging header). Well scratch that; I have different behaviour for two different 3.4.7 tasks now. Colour me confused.

@r-roos
Copy link

r-roos commented Sep 18, 2023

Also encountering this issue on Terrafrom v1.3.1 with AWS provider version: 5.17.0

Is there any known workaround which can be applied?

@yoni-yad2
Copy link

Waiting for a fix as well.
diffs always show up for historyTimeslotInMinutes + EnableLogContext

@rameshkumar20
Copy link

Same issue with us as well. Always showing historyTimeslotInMinutes + EnableLogContext as changed.
This lead to DMS task being modified everytime and impacts our CDC data capture effecting our production systems. Appreciate for early resolution.

Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
8 participants