Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/memory_db_cluster: Treat "snapshotting" status as pending when creating cluster #31077

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented May 1, 2023

Description

After this PR, Terraform can wait if MemoryDb cluster is in "snapshotting" status, instead of raising error.

Relations

Closes #29748

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccMemoryDBCluster_create_fromSnapshot PKG=memorydb

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_create_fromSnapshot'  -timeout 180m
=== RUN   TestAccMemoryDBCluster_create_fromSnapshot
=== PAUSE TestAccMemoryDBCluster_create_fromSnapshot
=== CONT  TestAccMemoryDBCluster_create_fromSnapshot

--- PASS: TestAccMemoryDBCluster_create_fromSnapshot (3877.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   3879.285s
...

@github-actions
Copy link

github-actions bot commented May 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/memorydb Issues and PRs that pertain to the memorydb service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 1, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @exoego 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@exoego exoego changed the title r/memory_db: Treat "snapshotting" status as pending when creating cluster from a snapshot r/memory_db: Treat "snapshotting" status as pending when creating cluster May 2, 2023
@exoego exoego force-pushed the b-memory_db-bugfix-29748 branch from 66565a4 to b640164 Compare May 2, 2023 06:55
@exoego exoego changed the title r/memory_db: Treat "snapshotting" status as pending when creating cluster r/memory_db_cluster: Treat "snapshotting" status as pending when creating cluster May 4, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 2, 2023
@exoego exoego force-pushed the b-memory_db-bugfix-29748 branch 2 times, most recently from e3ce52f to a66b138 Compare June 16, 2023 02:19
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 16, 2023
@github-actions github-actions bot removed the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 16, 2023
@exoego exoego marked this pull request as ready for review June 16, 2023 03:11
@johnsonaj johnsonaj self-assigned this Dec 15, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 15, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccMemoryDBCluster_" PKG=memorydb

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20  -run=TestAccMemoryDBCluster_ -timeout 360m
--- PASS: TestAccMemoryDBCluster_defaults (1524.72s)
--- PASS: TestAccMemoryDBCluster_Update_snapshotWindow (1737.97s)
--- PASS: TestAccMemoryDBCluster_create_withDataTiering (1806.71s)
--- PASS: TestAccMemoryDBCluster_create_withPort (2574.72s)
--- PASS: TestAccMemoryDBCluster_nameGenerated (2716.25s)
--- PASS: TestAccMemoryDBCluster_delete_withFinalSnapshot (2801.49s)
--- PASS: TestAccMemoryDBCluster_disappears (2880.11s)
--- PASS: TestAccMemoryDBCluster_Update_securityGroupIds (2927.40s)
--- PASS: TestAccMemoryDBCluster_basic (3121.74s)
--- PASS: TestAccMemoryDBCluster_create_noTLS (3634.22s)
--- PASS: TestAccMemoryDBCluster_Update_snapshotRetentionLimit (3701.32s)
--- PASS: TestAccMemoryDBCluster_Update_engineVersion (4117.16s)
--- PASS: TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleDown (2763.37s)
--- PASS: TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleUp (2583.49s)
--- PASS: TestAccMemoryDBCluster_Update_aclName (4807.49s)
--- PASS: TestAccMemoryDBCluster_Update_numShards_scaleDown (4866.18s)
--- PASS: TestAccMemoryDBCluster_namePrefix (5072.96s)
--- PASS: TestAccMemoryDBCluster_Update_tags (5162.49s)
--- PASS: TestAccMemoryDBCluster_Update_description (5749.86s)
--- PASS: TestAccMemoryDBCluster_Update_snsTopicARN (4047.36s)
--- PASS: TestAccMemoryDBCluster_Update_nodeType (3501.55s)
--- PASS: TestAccMemoryDBCluster_Update_parameterGroup (6165.76s)
--- PASS: TestAccMemoryDBCluster_Update_maintenanceWindow (3403.20s)
--- PASS: TestAccMemoryDBCluster_create_withKMS (6780.41s)
--- PASS: TestAccMemoryDBCluster_create_fromSnapshot (7171.11s)
--- PASS: TestAccMemoryDBCluster_Update_numShards_scaleUp (5036.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	7756.591s

@johnsonaj johnsonaj merged commit d5102ec into hashicorp:main Dec 18, 2023
36 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 18, 2023
@exoego exoego deleted the b-memory_db-bugfix-29748 branch December 18, 2023 21:26
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Jan 12, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/memorydb Issues and PRs that pertain to the memorydb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AWS MemoryDB Snapshotting state causes failure
3 participants