Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_guardduty_detector Lambda Protection support #30859

Closed
oleptho opened this issue Apr 21, 2023 · 5 comments · Fixed by #31463
Closed

[Enhancement]: aws_guardduty_detector Lambda Protection support #30859

oleptho opened this issue Apr 21, 2023 · 5 comments · Fixed by #31463
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Milestone

Comments

@oleptho
Copy link

oleptho commented Apr 21, 2023

Description

Amazon GuardDuty now supports Lambda Protection but the terraform resource for GuardDuty does not yet support it.

It would be great if we could enable GuardDuty Lambda Protection with terraform resource aws_guardduty_detector.

Affected Resource(s) and/or Data Source(s)

  • resource: aws_guardduty_detector
  • data: aws_guardduty_detector

Potential Terraform Configuration

resource "aws_guardduty_detector" "MyDetector" {
  enable = true

  datasources {
    s3_logs {
      enable = true
    }
    lambda_protection {
      enable = true
    }
    kubernetes {
      audit_logs {
        enable = false
      }
    }
    malware_protection {
      scan_ec2_instance_with_findings {
        ebs_volumes {
          enable = true
        }
      }
    }
  }
}

References

Would you like to implement a fix?

None

@oleptho oleptho added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Apr 21, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/guardduty Issues and PRs that pertain to the guardduty service. label Apr 21, 2023
@galoitsu
Copy link
Contributor

galoitsu commented Apr 21, 2023

GuardDuty API changes in March 2023#Mapping dataSources to features

According to the official documentation above, it appears that the DataSources attribute cannot be used to set Lambda protection and that the Features attribute must be used instead.

However, this provider does not currently support the Features attribute, so you cannot use this provider to set Lambda protection.

See #30303 .

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 25, 2023
@ewbankkit
Copy link
Contributor

You will be able to use the upcoming aws_guardduty_detector_feature resource (#31463):

resource "aws_guardduty_detector" "example" {
  enable = true
}

resource "aws_guardduty_detector_feature" "example" {
  detector_id = aws_guardduty_detector.example.id
  name        = "LAMBDA_NETWORK_LOGS"
  status      = "ENABLED"
}

@github-actions github-actions bot added this to the v5.20.0 milestone Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants