Allow movement of DMS tasks to new instances

[misterjacko]

Description

This change enables movement of DMS Tasks between DMS Instances in place rather than destroy and recreate by leveraging the MoveReplicatonTask operation.

Tests were also fixed so that they pass.

In addition, as mentioned in #29765 the 5 minute timeout for certain other actions is often not sufficient for how long DMS takes. While this PR does not address making those timeouts user configurable, it does increase that timeout and should reduce failures.

Relations

Closes #30709
Closes #29765

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccDMSReplicationTask PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_update
=== PAUSE TestAccDMSReplicationTask_update
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== RUN   TestAccDMSReplicationTask_s3ToRDS
=== PAUSE TestAccDMSReplicationTask_s3ToRDS
=== RUN   TestAccDMSReplicationTask_disappears
=== PAUSE TestAccDMSReplicationTask_disappears
=== CONT  TestAccDMSReplicationTask_basic
=== CONT  TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_disappears
=== CONT  TestAccDMSReplicationTask_s3ToRDS
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
=== CONT  TestAccDMSReplicationTask_update
--- PASS: TestAccDMSReplicationTask_disappears (1015.79s)
--- PASS: TestAccDMSReplicationTask_basic (1102.49s)
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (1195.71s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1281.19s)
--- PASS: TestAccDMSReplicationTask_update (1426.00s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1791.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1804.543s

...

New tests: #30721 (comment)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @misterjacko 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[misterjacko]

new test added and passed:

$ make testacc TESTS=TestAccDMSReplicationTask_move PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask_move'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_move
=== PAUSE TestAccDMSReplicationTask_move
=== CONT  TestAccDMSReplicationTask_move
--- PASS: TestAccDMSReplicationTask_move (1513.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1529.655s

[misterjacko]

Hi @justinretzolk ! Anything holding this up that I could address? Thanks for reviewing!

[justinretzolk]

Hey @misterjacko 👋 Thank you for taking the time to raise this, and for checking in on it! On a quick glance, everything looks to be in good shape for review. Unfortunately I can't provide an ETA on when this will be reviewed/merged due to the potential of shifting priorities. We prioritize by count of 👍 reactions and a few other things (more information on our prioritization guide if you're interested).

[ewbankkit]

@misterjacko Thanks for the contribution 🎉 👏.
These changes have been rolled into #34356.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.