Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dms_endpoint data source to dms resource. #30717

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Adding dms_endpoint data source to dms resource. #30717

merged 1 commit into from
Apr 19, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Apr 14, 2023 •
edited
Loading

Description

Added dms_endpoint data source to dms resource.

Relations

Relates #12713

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccDMSEndpointDataSource_basic' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSEndpointDataSource_basic -timeout 180m
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpointDataSource_basic
--- PASS: TestAccDMSEndpointDataSource_basic (14.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        17.435s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Apr 14, 2023
@nam054 nam054 force-pushed the f-endpt-dms-datasource branch 6 times, most recently from 5c517c1 to 4ccd9e2 Compare April 18, 2023 19:07
@nam054 nam054 marked this pull request as ready for review April 18, 2023 19:31
jar-b
jar-b reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great, just a couple small suggestions.

internal/service/dms/endpoint_data_source.go Outdated Show resolved Hide resolved
internal/service/dms/endpoint_data_source.go Outdated Show resolved Hide resolved
internal/service/dms/endpoint_data_source_test.go Outdated Show resolved Hide resolved
@nam054 nam054 force-pushed the f-endpt-dms-datasource branch from 4ccd9e2 to fa7304f Compare April 19, 2023 01:11
jar-b
jar-b approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=dms TESTS=TestAccDMSEndpointDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpointDataSource_'  -timeout 180m
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpointDataSource_basic
--- PASS: TestAccDMSEndpointDataSource_basic (26.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        29.962s

@nam054 nam054 merged commit 9d320d8 into main Apr 19, 2023
@nam054 nam054 deleted the f-endpt-dms-datasource branch April 19, 2023 16:54
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 19, 2023
@ewbankkit ewbankkit mentioned this pull request Apr 19, 2023
Merged
ewbankkit added a commit that referenced this pull request Apr 19, 2023
@ewbankkit
Missing CHANGELOG entry #30717.
0c8251e
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nam054 @jar-b