-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default timeout for aws_ec2_client_vpn_route #30552
Conversation
When creating the resource aws_ec2_client_vpn_route, AWS takes between 2 and 3 minutes to create and activate the route, That means the default setting of 1 minute, is not enough, and would most likely fail to either create OR delete. I propose to raise the default timeout to 4 minutes, which is a lot of time, sure, but for https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/eks/node_group.go#L38 Node_group timeout is an hour, but node groups are usually active within the first 15 minutes, so I took some headroom as well..
Community NoteVoting for Prioritization
For Submitters
|
Feel free to modify my PR 👐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@asaf400 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
When creating the resource aws_ec2_client_vpn_route, AWS takes between 2 and 3 minutes to create and activate the route, That means the default setting of 1 minute, is not enough, and would most likely fail to either create OR delete.
I propose to raise the default timeout to 4 minutes, which is a lot of time, sure, but for https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/eks/node_group.go#L38 Node_group timeout is an hour, but node groups are usually active within the first 15 minutes, so I took some headroom as well..
This, to the best of my knowledge is not an open issue, but rather something I encountered while creating a resource of
aws_ec2_client_vpn_route
.Closes: #23787.