-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_ecs_cluster - add tags attribute #30073
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSClusterDataSource_' PKG=ecs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 2 -run=TestAccECSClusterDataSource_ -timeout 180m
=== RUN TestAccECSClusterDataSource_ecsCluster
=== PAUSE TestAccECSClusterDataSource_ecsCluster
=== RUN TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== RUN TestAccECSClusterDataSource_tags
=== PAUSE TestAccECSClusterDataSource_tags
=== CONT TestAccECSClusterDataSource_ecsCluster
=== CONT TestAccECSClusterDataSource_tags
--- PASS: TestAccECSClusterDataSource_tags (25.76s)
=== CONT TestAccECSClusterDataSource_ecsClusterContainerInsights
--- PASS: TestAccECSClusterDataSource_ecsCluster (25.83s)
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (23.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 54.650s
@mtt88 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds
tags
to theaws_ecs_cluster
data source.Relations
Closes #29420
Output from Acceptance Testing