Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Api Gateway Domain Name being recreated when truststore is changed #29970

Closed
thezeroend opened this issue Mar 13, 2023 · 3 comments · Fixed by #30081
Closed

[Bug]: Api Gateway Domain Name being recreated when truststore is changed #29970

thezeroend opened this issue Mar 13, 2023 · 3 comments · Fixed by #30081
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Milestone

Comments

@thezeroend
Copy link
Contributor

Terraform Core Version

1.4.0

AWS Provider Version

4.58.0

Affected Resource(s)

aws_api_gateway_domain_name

Expected Behavior

By changing the truststore path, it should update the resource and not recreate it, as it happens in the console.

Actual Behavior

When a change in the truststore path is detected, it forces a redeployment, where it deletes the current resource and creates a new one, and because it is a unique regional resource, it makes it impossible to use lifecycle definitions.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_api_gateway_domain_name" "example" {
  domain_name              = "thezeroend.click"
  regional_certificate_arn = "arn:aws:acm:us-east-1:ACCOUNT_ID:certificate/CERTIFICATE_ID"

  endpoint_configuration {
    types = ["REGIONAL"]
  }

  mutual_tls_authentication {
    truststore_uri = "s3://testebucket-gw/domain/cert1.crt"
  }
}

Steps to Reproduce

  1. Create certificate in ACM by Amazon
  2. Create domain name resource with mTLS pointing to an s3 bucket ex. s3://testebucket-gw/domain/cert1.crt
  3. Run Plan & Apply
  4. Change the s3 path in the parameters where you should look for the truststore ex. s3://testebucket-gw/domain/cert2.crt
  5. Run Plan & Apply

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@thezeroend thezeroend added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Mar 13, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/apigateway Issues and PRs that pertain to the apigateway service. label Mar 13, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2023
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 17, 2023
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants