Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sensitivity level parameter is not available in sqli_match_statement (aws_wafv2_web_acl resource #29672

Closed
tamilver-amzn opened this issue Feb 27, 2023 · 5 comments · Fixed by #38077
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@tamilver-amzn
Copy link

Terraform Core Version

latest

AWS Provider Version

latest

Affected Resource(s)

aws_waf_web_acl sqli_match_statement

Expected Behavior

Since sensitivity parameter is not available, waf sqli_match_statement is creating without SensitivityLevel. This value either it is LOW or HIGH.

Refer: https://aws.amazon.com/about-aws/whats-new/2022/07/aws-waf-sensitivity-levels-sql-injection-rule-statements/

This is available in cloudformation not in terraform.

Actual Behavior

Since SensitivityLevel parameter is not available, WAF rule is getting creating without that value.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

NA

Steps to Reproduce

terraform init
terraform apply

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@tamilver-amzn tamilver-amzn added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Feb 27, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels May 3, 2023
@tyler-robbins2
Copy link

Hi there,

We are trying to follow the recommendations from this article: https://docs.aws.amazon.com/en_us/waf/latest/developerguide/waf-rule-statement-type-sqli-match.html

The HIGH setting detects more SQL injection attacks, and is the recommended setting.

Is there any movement on this enhancement/bug?

We have to manually modify the value to HIGH in the AWS WAF UI, which breaks terraform state and gets overwritten whenever we update.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.56.0 milestone Jun 24, 2024
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants