Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_glue_crawler: Add create_native_delta_table option to delta_target block #29566

Conversation

tomwelsh11
Copy link
Contributor

@tomwelsh11 tomwelsh11 commented Feb 22, 2023

Description

  • Adds create_native_delta_table option to delta_target_block
  • Support added for this by AWS at the end of last year
  • Pretty small change (pretty much directly passing through from option from the AWS SDK)

Relations

Closes #29336

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccGlueCrawler_deltaTarget PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCrawler_deltaTarget'  -timeout 180m
=== RUN   TestAccGlueCrawler_deltaTarget
=== PAUSE TestAccGlueCrawler_deltaTarget
=== CONT  TestAccGlueCrawler_deltaTarget
--- PASS: TestAccGlueCrawler_deltaTarget (58.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       63.243s

screenshot attached as proof
image

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Feb 22, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 10, 2023
@ewbankkit ewbankkit self-assigned this Mar 10, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 10, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlueCrawler_deltaTarget' PKG=glue ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 3  -run=TestAccGlueCrawler_deltaTarget -timeout 180m
=== RUN   TestAccGlueCrawler_deltaTarget
=== PAUSE TestAccGlueCrawler_deltaTarget
=== CONT  TestAccGlueCrawler_deltaTarget
--- PASS: TestAccGlueCrawler_deltaTarget (48.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	57.046s
% make testacc TESTARGS='-run=TestAccGlueCrawler_dynamoDBTarget' PKG=glue ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 3  -run=TestAccGlueCrawler_dynamoDBTarget -timeout 180m
=== RUN   TestAccGlueCrawler_dynamoDBTarget
=== PAUSE TestAccGlueCrawler_dynamoDBTarget
=== CONT  TestAccGlueCrawler_dynamoDBTarget
--- PASS: TestAccGlueCrawler_dynamoDBTarget (39.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	44.804s

@ewbankkit
Copy link
Contributor

@tomwelsh11 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f3c2c02 into hashicorp:main Mar 10, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 10, 2023
@tomwelsh11 tomwelsh11 deleted the f-aws_glue_crawler-delta-target-create-native-delta-table branch March 10, 2023 21:16
@tomwelsh11
Copy link
Contributor Author

Thanks @ewbankkit!

@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_glue_crawler with delta_target does not contain Create Native Tables option
3 participants