Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_prometheus_workspaces: Add New Data Source #28574

Merged

Conversation

cbbond
Copy link

@cbbond cbbond commented Dec 24, 2022

Description

This PR adds a new data source aws_prometheus_workspaces for listing AMP workspaces. The data source is filterable by an alias_prefix argument.

#26120 added the ability to query a workspace by ID. As issue #26400 mentions, the workspace ID is generated and not a user-friendly way to search for a workspace. The aws_prometheus_workspaces data source allows a user to get a list of aliases, ARNs, and workspace IDs of all workspaces that begin with a given alias. This makes the aws_prometheus_workspace datasource easier to use.

Aliases are not unique, so it was not possible to extend the aws_prometheus_workspace datasource to accept an alias argument.

Relations

Closes #26400.
Closes #27039.
Closes #27859.

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccAMPWorkspacesDataSource_' PKG=amp ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 1  -run=TestAccAMPWorkspacesDataSource_ -timeout 180m
=== RUN   TestAccAMPWorkspacesDataSource_basic
--- PASS: TestAccAMPWorkspacesDataSource_basic (27.62s)
=== RUN   TestAccAMPWorkspacesDataSource_aliasPrefix
--- PASS: TestAccAMPWorkspacesDataSource_aliasPrefix (16.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	46.495s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/amp Issues and PRs that pertain to the amp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 24, 2022
@DrFaust92 DrFaust92 added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 24, 2022
@github-actions github-actions bot added generators Relates to code generators. and removed generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 17, 2023
@github-actions github-actions bot added the generators Relates to code generators. label Apr 17, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAMPWorkspacesDataSource_' PKG=amp ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 3  -run=TestAccAMPWorkspacesDataSource_ -timeout 180m
=== RUN   TestAccAMPWorkspacesDataSource_basic
--- PASS: TestAccAMPWorkspacesDataSource_basic (28.43s)
=== RUN   TestAccAMPWorkspacesDataSource_aliasPrefix
--- PASS: TestAccAMPWorkspacesDataSource_aliasPrefix (15.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	49.720s

@ewbankkit
Copy link
Contributor

@cbbond Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6f8f9ee into hashicorp:main Apr 17, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 17, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/amp Issues and PRs that pertain to the amp service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants