-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_prometheus_workspaces: Add New Data Source #28574
d/aws_prometheus_workspaces: Add New Data Source #28574
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAMPWorkspacesDataSource_' PKG=amp ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 3 -run=TestAccAMPWorkspacesDataSource_ -timeout 180m
=== RUN TestAccAMPWorkspacesDataSource_basic
--- PASS: TestAccAMPWorkspacesDataSource_basic (28.43s)
=== RUN TestAccAMPWorkspacesDataSource_aliasPrefix
--- PASS: TestAccAMPWorkspacesDataSource_aliasPrefix (15.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 49.720s
@cbbond Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds a new data source
aws_prometheus_workspaces
for listing AMP workspaces. The data source is filterable by analias_prefix
argument.#26120 added the ability to query a workspace by ID. As issue #26400 mentions, the workspace ID is generated and not a user-friendly way to search for a workspace. The
aws_prometheus_workspaces
data source allows a user to get a list of aliases, ARNs, and workspace IDs of all workspaces that begin with a given alias. This makes theaws_prometheus_workspace
datasource easier to use.Aliases are not unique, so it was not possible to extend the
aws_prometheus_workspace
datasource to accept analias
argument.Relations
Closes #26400.
Closes #27039.
Closes #27859.
Output from Acceptance Testing