-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticache ip discovery #27856
Add elasticache ip discovery #27856
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @jms200 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Working with @bschaatsbergen to run tests soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_redis\|TestAccElastiCacheCluster_ipDiscovery' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheCluster_Engine_redis\|TestAccElastiCacheCluster_ipDiscovery -timeout 180m
=== RUN TestAccElastiCacheCluster_Engine_redis
=== PAUSE TestAccElastiCacheCluster_Engine_redis
=== RUN TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN TestAccElastiCacheCluster_ipDiscovery
=== PAUSE TestAccElastiCacheCluster_ipDiscovery
=== CONT TestAccElastiCacheCluster_Engine_redis
=== CONT TestAccElastiCacheCluster_ipDiscovery
--- PASS: TestAccElastiCacheCluster_Engine_redis (522.11s)
=== CONT TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheCluster_ipDiscovery (527.74s)
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (447.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 974.021s
This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
ip_discovery
parameter to elasticache cluster creation that is now supported on Redis 6.2 and Memcached engine version 1.6.6 on all instances built on the Nitro system.Also seen in the official announcement here: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-elasticache-supports-ipv6/
Relations
Closes #27700
References
Announcement: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-elasticache-supports-ipv6/
API: https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateCacheCluster.html
Output from Acceptance Testing