-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_lightsail_lb_stickiness_policy
#27514
New Resource: aws_lightsail_lb_stickiness_policy
#27514
Conversation
Community NoteVoting for Prioritization
For Submitters
|
* update `enabled` to be required, this allows the configuration to enable or disable session stickiness.
* update docs to include enabled field.
Updated Resource to support enabling or disabling session stickiness, added tests to verify:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLightsailLoadBalancerStickinessPolicy_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2 -run=TestAccLightsailLoadBalancerStickinessPolicy_ -timeout 180m
=== RUN TestAccLightsailLoadBalancerStickinessPolicy_basic
=== PAUSE TestAccLightsailLoadBalancerStickinessPolicy_basic
=== RUN TestAccLightsailLoadBalancerStickinessPolicy_CookieDuration
=== PAUSE TestAccLightsailLoadBalancerStickinessPolicy_CookieDuration
=== RUN TestAccLightsailLoadBalancerStickinessPolicy_Enabled
=== PAUSE TestAccLightsailLoadBalancerStickinessPolicy_Enabled
=== RUN TestAccLightsailLoadBalancerStickinessPolicy_disappears
=== PAUSE TestAccLightsailLoadBalancerStickinessPolicy_disappears
=== CONT TestAccLightsailLoadBalancerStickinessPolicy_basic
=== CONT TestAccLightsailLoadBalancerStickinessPolicy_Enabled
--- PASS: TestAccLightsailLoadBalancerStickinessPolicy_basic (146.11s)
=== CONT TestAccLightsailLoadBalancerStickinessPolicy_CookieDuration
--- PASS: TestAccLightsailLoadBalancerStickinessPolicy_Enabled (172.51s)
=== CONT TestAccLightsailLoadBalancerStickinessPolicy_disappears
--- PASS: TestAccLightsailLoadBalancerStickinessPolicy_CookieDuration (159.81s)
--- PASS: TestAccLightsailLoadBalancerStickinessPolicy_disappears (172.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lightsail 348.899s
@brittandeyoung Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds a new
aws_lightsail_lb_stickiness_policy
resource. This allows management of Stickiness settings on Lightsail Load balancers.Relations
References
Output from Acceptance Testing