-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource aws_ec2_transit_gateway_policy_table
and aws_ec2_transit_gateway_policy_table_association
#26264
New resource aws_ec2_transit_gateway_policy_table
and aws_ec2_transit_gateway_policy_table_association
#26264
Conversation
aws_ec2_transit_gateway_policy_table
aws_ec2_transit_gateway_policy_table
and aws_ec2_transit_gateway_policy_table_association
13e8e05
to
982608b
Compare
Almost ready for review - busy figuring out the resources I need to create for the |
…anager_transit_gateway_peering.transit_gateway_peering_attachment_id'.
This comment was marked as resolved.
This comment was marked as resolved.
… Delete timeouts to 20 minutes.
…ce test corrections.
…tribute (matches r/aws_ec2_transit_gateway_route_table_association).
…existing TGW route table on the attachment.
…nalProviders for acceptance tests (awscc_networkmanager_core_network).
… checks for 'core_network_arn' and 'core_network_id'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_ -timeout 180m
=== RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== CONT TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (1973.85s)
=== CONT TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (2113.93s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears (1678.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 3345.295s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTableAssociation/basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/PolicyTableAssociation/basic -timeout 180m
=== RUN TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN TestAccTransitGateway_serial/PolicyTableAssociation/basic
--- PASS: TestAccTransitGateway_serial (1388.22s)
--- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (1388.22s)
--- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/basic (1388.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1392.618s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTableAssociation/disappears' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/PolicyTableAssociation/disappears -timeout 180m
=== RUN TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN TestAccTransitGateway_serial/PolicyTableAssociation/disappears
--- PASS: TestAccTransitGateway_serial (1450.77s)
--- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (1450.77s)
--- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/disappears (1450.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1454.645s
% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayPeering_' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerTransitGatewayPeering_ -timeout 180m
=== RUN TestAccNetworkManagerTransitGatewayPeering_basic
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_basic
=== RUN TestAccNetworkManagerTransitGatewayPeering_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_disappears
=== RUN TestAccNetworkManagerTransitGatewayPeering_tags
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_tags
=== CONT TestAccNetworkManagerTransitGatewayPeering_basic
=== CONT TestAccNetworkManagerTransitGatewayPeering_tags
--- PASS: TestAccNetworkManagerTransitGatewayPeering_tags (1487.08s)
=== CONT TestAccNetworkManagerTransitGatewayPeering_disappears
--- PASS: TestAccNetworkManagerTransitGatewayPeering_basic (1627.88s)
--- PASS: TestAccNetworkManagerTransitGatewayPeering_disappears (1279.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 2770.823s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTable/basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/PolicyTable/basic -timeout 180m
=== RUN TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/PolicyTable
=== RUN TestAccTransitGateway_serial/PolicyTable/basic
=== RUN TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN TestAccTransitGateway_serial/PolicyTableAssociation/basic
--- PASS: TestAccTransitGateway_serial (1724.02s)
--- PASS: TestAccTransitGateway_serial/PolicyTable (200.15s)
--- PASS: TestAccTransitGateway_serial/PolicyTable/basic (200.15s)
--- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (1523.87s)
--- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/basic (1523.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1728.558s
This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #26093.
Closes #26222.
Relates #25835.
Output from acceptance testing: