Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolesanywhere profile resource #25850

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Rolesanywhere profile resource #25850

merged 2 commits into from
Jul 19, 2022

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jul 17, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #25727

Output from acceptance testing:

$ make testacc TESTS=TestAccRolesAnywhereProfile PKG=rolesanywhere
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rolesanywhere/... -v -count 1 -parallel 20 -run='TestAccRolesAnywhereProfile'  -timeout 180m
=== RUN   TestAccRolesAnywhereProfile_basic
=== PAUSE TestAccRolesAnywhereProfile_basic
=== RUN   TestAccRolesAnywhereProfile_tags
=== PAUSE TestAccRolesAnywhereProfile_tags
=== RUN   TestAccRolesAnywhereProfile_disappears
=== PAUSE TestAccRolesAnywhereProfile_disappears
=== CONT  TestAccRolesAnywhereProfile_basic
=== CONT  TestAccRolesAnywhereProfile_disappears
=== CONT  TestAccRolesAnywhereProfile_tags
--- PASS: TestAccRolesAnywhereProfile_basic (19.49s)
--- PASS: TestAccRolesAnywhereProfile_disappears (21.35s)
--- PASS: TestAccRolesAnywhereProfile_tags (45.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere	45.640s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 17, 2022
@mattburgess
Copy link
Collaborator Author

Draft PR - will rebase once #25779 is merged.

@mattburgess mattburgess force-pushed the rolesanywhere-profile-resource branch 2 times, most recently from 2a5b994 to 0d4abd1 Compare July 18, 2022 20:16
@github-actions github-actions bot removed client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. tags Pertains to resource tagging. labels Jul 18, 2022
@mattburgess mattburgess force-pushed the rolesanywhere-profile-resource branch from 0d4abd1 to a6f4208 Compare July 18, 2022 20:20
@mattburgess mattburgess force-pushed the rolesanywhere-profile-resource branch from a6f4208 to 3868756 Compare July 18, 2022 20:23
@mattburgess mattburgess marked this pull request as ready for review July 18, 2022 20:25
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Jul 19, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 19, 2022
ewbankkit
ewbankkit approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRolesAnywhereProfile_' PKG=rolesanywhere ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rolesanywhere/... -v -count 1 -parallel 2  -run=TestAccRolesAnywhereProfile_ -timeout 180m
=== RUN   TestAccRolesAnywhereProfile_basic
=== PAUSE TestAccRolesAnywhereProfile_basic
=== RUN   TestAccRolesAnywhereProfile_tags
=== PAUSE TestAccRolesAnywhereProfile_tags
=== RUN   TestAccRolesAnywhereProfile_disappears
=== PAUSE TestAccRolesAnywhereProfile_disappears
=== CONT  TestAccRolesAnywhereProfile_basic
=== CONT  TestAccRolesAnywhereProfile_disappears
--- PASS: TestAccRolesAnywhereProfile_disappears (18.22s)
=== CONT  TestAccRolesAnywhereProfile_tags
--- PASS: TestAccRolesAnywhereProfile_basic (21.14s)
--- PASS: TestAccRolesAnywhereProfile_tags (42.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere	64.633s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit mentioned this pull request Jul 19, 2022
Closed
3 tasks
@ewbankkit ewbankkit merged commit 66d3e4b into hashicorp:main Jul 19, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 19, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mattburgess @ewbankkit