Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_fsx_openzfs_volume Does not report errors on Update #25842

Closed
troy-f opened this issue Jul 16, 2022 · 2 comments · Fixed by #33245
Closed

aws_fsx_openzfs_volume Does not report errors on Update #25842

troy-f opened this issue Jul 16, 2022 · 2 comments · Fixed by #33245
Labels
bug Addresses a defect in current functionality. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@troy-f
Copy link
Contributor

troy-f commented Jul 16, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v1.2.5
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v4.22.0

Affected Resource(s)

  • aws_fsx_openzfs_volume

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

  resource "aws_fsx_openzfs_volume" "this" {
        id                               = "fsvol-03b9808aa16464b8a"
        name                             = "test-volume"
        storage_capacity_quota_gib       = 100 -> 110
        storage_capacity_reservation_gib = 100 -> 110
        tags                             = {
            "Name" = "test-volume"
        }
        # (7 unchanged attributes hidden)


        # (3 unchanged blocks hidden)
    }

Expected Behavior

Error message that increasing the reservation to 110 is not possible. This is AdministrativeActionTypeVolumeUpdate in the go sdk.

Actual Behavior

Terraform acts like everything is fine and finished, even though nothing was applied. This also has the side effect of not applying anything else related to the volume, like trying to change compression settings.

Steps to Reproduce

make a zfs filesystem. make a volume. make an update by setting the volume's quota/reserved data size to larger then the filesystem.

Important Factoids

There should be an AdministrativeActionCompleted type check here, I tried copying the one from aws_fsx_openzfs_file_system, but that call expects fs- id not fsvol- id

References

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/fsx Issues and PRs that pertain to the fsx service. labels Jul 16, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 18, 2022
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants