r/aws_cost_categories: Fix parameter expansion and update values type to schema.TypeList

[joakimhew]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR closes #25487 and fixes an issue where the cost_category schema (split_charge_rule.parameter.values) is of incorrect type as well as incorrect implementation of expandCostCategorySplitChargeRuleParameter where it's trying to expand non-existent field method while it should be expanding type

Output from acceptance testing:

$ make testacc TESTS=TestAccCECostCategory_splitCharge PKG=ce

=== RUN   TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== CONT  TestAccCECostCategory_splitCharge
--- PASS: TestAccCECostCategory_splitCharge (49.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ce 51.593s

[github-actions]

Welcome @joakimhew 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[prolinsin]

LGTM

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCECostCategory_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 2  -run=TestAccCECostCategory_ -timeout 180m
=== RUN   TestAccCECostCategory_basic
=== PAUSE TestAccCECostCategory_basic
=== RUN   TestAccCECostCategory_complete
=== PAUSE TestAccCECostCategory_complete
=== RUN   TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== RUN   TestAccCECostCategory_disappears
=== PAUSE TestAccCECostCategory_disappears
=== CONT  TestAccCECostCategory_basic
=== CONT  TestAccCECostCategory_splitCharge
--- PASS: TestAccCECostCategory_basic (22.68s)
=== CONT  TestAccCECostCategory_disappears
--- PASS: TestAccCECostCategory_disappears (16.90s)
=== CONT  TestAccCECostCategory_complete
--- PASS: TestAccCECostCategory_splitCharge (41.44s)
--- PASS: TestAccCECostCategory_complete (29.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	77.768s

[ewbankkit]

@joakimhew Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.