-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b/aws_cloudwatch_event_target: remove default value from ecs_target.propagate_tags #25233
b/aws_cloudwatch_event_target: remove default value from ecs_target.propagate_tags #25233
Conversation
# Conflicts: # internal/service/events/target.go # internal/service/events/target_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEventsTarget_' PKG=events ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 2 -run=TestAccEventsTarget_ -timeout 180m
=== RUN TestAccEventsTarget_basic
=== PAUSE TestAccEventsTarget_basic
=== RUN TestAccEventsTarget_disappears
=== PAUSE TestAccEventsTarget_disappears
=== RUN TestAccEventsTarget_eventBusName
=== PAUSE TestAccEventsTarget_eventBusName
=== RUN TestAccEventsTarget_eventBusARN
=== PAUSE TestAccEventsTarget_eventBusARN
=== RUN TestAccEventsTarget_generatedTargetID
=== PAUSE TestAccEventsTarget_generatedTargetID
=== RUN TestAccEventsTarget_RetryPolicy_deadLetter
=== PAUSE TestAccEventsTarget_RetryPolicy_deadLetter
=== RUN TestAccEventsTarget_full
=== PAUSE TestAccEventsTarget_full
=== RUN TestAccEventsTarget_ssmDocument
=== PAUSE TestAccEventsTarget_ssmDocument
=== RUN TestAccEventsTarget_http
=== PAUSE TestAccEventsTarget_http
=== RUN TestAccEventsTarget_http_params
=== PAUSE TestAccEventsTarget_http_params
=== RUN TestAccEventsTarget_ecs
=== PAUSE TestAccEventsTarget_ecs
=== RUN TestAccEventsTarget_redshift
=== PAUSE TestAccEventsTarget_redshift
=== RUN TestAccEventsTarget_ecsWithoutLaunchType
=== PAUSE TestAccEventsTarget_ecsWithoutLaunchType
=== RUN TestAccEventsTarget_ecsWithBlankLaunchType
=== PAUSE TestAccEventsTarget_ecsWithBlankLaunchType
=== RUN TestAccEventsTarget_ecsWithBlankTaskCount
=== PAUSE TestAccEventsTarget_ecsWithBlankTaskCount
=== RUN TestAccEventsTarget_ecsFull
=== PAUSE TestAccEventsTarget_ecsFull
=== RUN TestAccEventsTarget_ecsCapacityProvider
=== PAUSE TestAccEventsTarget_ecsCapacityProvider
=== RUN TestAccEventsTarget_ecsPlacementStrategy
=== PAUSE TestAccEventsTarget_ecsPlacementStrategy
=== RUN TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== RUN TestAccEventsTarget_kinesis
=== PAUSE TestAccEventsTarget_kinesis
=== RUN TestAccEventsTarget_sqs
=== PAUSE TestAccEventsTarget_sqs
=== RUN TestAccEventsTarget_Input_transformer
=== PAUSE TestAccEventsTarget_Input_transformer
=== RUN TestAccEventsTarget_inputTransformerJSONString
=== PAUSE TestAccEventsTarget_inputTransformerJSONString
=== RUN TestAccEventsTarget_partnerEventBus
target_test.go:907: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsTarget_partnerEventBus (0.00s)
=== RUN TestAccEventsTarget_ecsNoPropagateTags
=== PAUSE TestAccEventsTarget_ecsNoPropagateTags
=== CONT TestAccEventsTarget_basic
=== CONT TestAccEventsTarget_ecsWithoutLaunchType
--- PASS: TestAccEventsTarget_basic (28.71s)
=== CONT TestAccEventsTarget_full
--- PASS: TestAccEventsTarget_full (48.17s)
=== CONT TestAccEventsTarget_redshift
--- PASS: TestAccEventsTarget_ecsWithoutLaunchType (301.68s)
=== CONT TestAccEventsTarget_ecs
--- PASS: TestAccEventsTarget_redshift (230.20s)
=== CONT TestAccEventsTarget_http_params
--- PASS: TestAccEventsTarget_ecs (31.96s)
=== CONT TestAccEventsTarget_http
--- PASS: TestAccEventsTarget_http_params (31.05s)
=== CONT TestAccEventsTarget_ssmDocument
--- PASS: TestAccEventsTarget_ssmDocument (19.47s)
=== CONT TestAccEventsTarget_eventBusARN
--- PASS: TestAccEventsTarget_http (43.63s)
=== CONT TestAccEventsTarget_RetryPolicy_deadLetter
--- PASS: TestAccEventsTarget_eventBusARN (19.56s)
=== CONT TestAccEventsTarget_generatedTargetID
--- PASS: TestAccEventsTarget_generatedTargetID (18.30s)
=== CONT TestAccEventsTarget_eventBusName
--- PASS: TestAccEventsTarget_eventBusName (19.96s)
=== CONT TestAccEventsTarget_ecsFull
--- PASS: TestAccEventsTarget_RetryPolicy_deadLetter (56.24s)
=== CONT TestAccEventsTarget_ecsPlacementStrategy
--- PASS: TestAccEventsTarget_ecsFull (33.50s)
=== CONT TestAccEventsTarget_ecsCapacityProvider
--- PASS: TestAccEventsTarget_ecsPlacementStrategy (88.14s)
=== CONT TestAccEventsTarget_disappears
--- PASS: TestAccEventsTarget_ecsCapacityProvider (68.94s)
=== CONT TestAccEventsTarget_Input_transformer
--- PASS: TestAccEventsTarget_disappears (15.03s)
=== CONT TestAccEventsTarget_ecsNoPropagateTags
--- PASS: TestAccEventsTarget_ecsNoPropagateTags (32.26s)
=== CONT TestAccEventsTarget_inputTransformerJSONString
--- PASS: TestAccEventsTarget_Input_transformer (42.10s)
=== CONT TestAccEventsTarget_sqs
--- PASS: TestAccEventsTarget_inputTransformerJSONString (33.69s)
=== CONT TestAccEventsTarget_ecsWithBlankTaskCount
--- PASS: TestAccEventsTarget_ecsWithBlankTaskCount (32.51s)
=== CONT TestAccEventsTarget_ecsWithBlankLaunchType
--- PASS: TestAccEventsTarget_sqs (47.27s)
=== CONT TestAccEventsTarget_kinesis
--- PASS: TestAccEventsTarget_kinesis (49.30s)
=== CONT TestAccEventsTarget_batch
--- PASS: TestAccEventsTarget_batch (110.29s)
--- PASS: TestAccEventsTarget_ecsWithBlankLaunchType (283.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 892.826s
@atsushi-ishibashi Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25231
Output from acceptance testing: