Adding Skip Matching Preference to AutoScaling Group Instance Refresh

[celestialorb]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR simply adds in a new field in the schema for the instance refresh preferences block for an autoscaling group, which maps to the "skip matching" parameter for an instance refresh call.

Closes #22554

Output from acceptance testing:

$ make testacc TESTS="TestAccAutoScalingGroup_InstanceRefresh_" PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroup_InstanceRefresh_'  -timeout 180m
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (151.37s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (230.40s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (240.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        240.303s

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_InstanceRefresh' PKG=autoscaling ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_InstanceRefresh -timeout 180m
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (218.80s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (308.47s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (254.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	477.743s

[ewbankkit]

@celestialorb Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.