r/aws_kinesis_firehose_delivery_stream: Deprecate root-level s3_configuration and add nested s3_configuration blocks in-line with API

[anGie44]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Both the AWS documentation and our resource documentation (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kinesis_firehose_delivery_stream#s3_configuration) note that s3_configuration is deprecated and extended_s3_configuration should be used instead for the case of s3 destinations. For other available destinations such as elasticsearch and to avoid confusion with the deprecation notice, it's possible to include an s3_configuration nested block per applicable destination.

Expected Changes

The changes would include:

1. deprecate the root-level s3_configuration as expected (later to be removed in 4.0 milestone)
2. add s3_configuration blocks where needed to match the upstream API
   a. in elasticsearch_configuration
   b. in http_endpoint_configuration
   c. in redshift_configuration
   d. in splunk_configuration

Affected issues

• Kinesis Firehose Delivery Streams, S3 Configuration doesn't support error_output_prefix #7997
• r/aws_kinesis_firehose_delivery_stream: Add support for s3 custom prefixes #7953

[umpa385]

agreed same issue here as well, can't use extended_s3_configuration with splunk_configuration.

[johnsonaj]

Closed in #31138

[github-actions]

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.