-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MemberStatus values to the currently available through the AWS… #16404
Update MemberStatus values to the currently available through the AWS… #16404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @reactiveinactive 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Please note that I'm holding off on merging this as-is, since the service team may opt to rollback the change since it breaks all previous Terraform AWS Provider versions. We could temporarily support both the previous and new value if we wanted to get this in immediately without risk of the API changing again. |
(In the meantime, for anyone 👍 reacting here, you may also want to 👍 react to the issue itself: #16403 so there's accurate tracking of those affected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for raising this, @reactiveinactive
Since AWS China (and potentially other AWS partitions) do not support the new Organizations integration that caused this breaking API change:
- https://aws.amazon.com/about-aws/whats-new/2020/11/aws-security-hub-integrates-with-aws-organizations-for-simplified-security-posture-management/
- https://forums.aws.amazon.com/ann.jspa?annID=8164)
- https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-regions.html
We will need to support both old and new values for now. Once this is in, we should be able to merge this and release it in the next day or two.
@bflad looks ok to me, do I need to do anything else? First time doing a pull request so not entirely sure on how this all works. |
Co-authored-by: Brian Flad <[email protected]>
Co-authored-by: Brian Flad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for this fix, @reactiveinactive 🚀
Output from acceptance testing:
--- PASS: TestAccAWSSecurityHub_serial (29.45s)
--- PASS: TestAccAWSSecurityHub_serial/Member (29.45s)
--- PASS: TestAccAWSSecurityHub_serial/Member/basic (15.06s)
--- PASS: TestAccAWSSecurityHub_serial/Member/invite (14.39s)
This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #16403
Release note for CHANGELOG:
Output from acceptance testing: