Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_accessanalyzer_analyzer: Adds correct validation to analyzer_name #16265

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

gdavison
Copy link
Contributor

Adds validation to aws_accessanalyzer_analyzer analyzer_name

Closes #16264

Release note for CHANGELOG:

* resource/aws_accessanalyzer_analyzer: Adds plan time validation to `analyzer_name`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@gdavison gdavison requested a review from a team as a code owner November 17, 2020 23:40
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. labels Nov 17, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 18, 2020
@bflad bflad self-assigned this Nov 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential message improvement, but otherwise looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAccessAnalyzer_serial (314.92s)
    --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer (314.92s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/basic (10.26s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/disappears (6.83s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/Tags (24.45s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/Type_Organization (273.37s)

aws/resource_aws_accessanalyzer_analyzer.go Outdated Show resolved Hide resolved
@gdavison gdavison added this to the v3.17.0 milestone Nov 18, 2020
@gdavison gdavison merged commit 7c1e71a into master Nov 18, 2020
@gdavison gdavison deleted the b-accessanalyzer-name-validation branch November 18, 2020 21:09
gdavison added a commit that referenced this pull request Nov 18, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM Access Analyzer does not validate analyzer name
2 participants