New Resource: aws_imagebuilder_image_recipe #16218

bflad · 2020-11-16T20:59:32Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #11084
Reference: #13485

Release note for CHANGELOG:

* **New Data Source:** `aws_imagebuilder_image_recipe`
* **New Resource:** `aws_imagebuilder_image_recipe`

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsImageBuilderImageRecipe_basic (38.20s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (35.14s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (34.64s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (33.35s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (36.82s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (35.17s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (57.27s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (35.26s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (37.01s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (35.18s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (34.55s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (34.98s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (31.67s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (59.07s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (19.90s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAwsImageBuilderImageRecipe_basic (25.73s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (39.43s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (39.12s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (39.21s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (39.20s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (39.29s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (59.68s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (39.29s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (38.94s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (38.10s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (39.09s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (38.84s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (34.09s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (68.88s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (24.71s)

Output from sweeper in AWS Commercial:

2020/11/16 15:31:54 [DEBUG] Running Sweepers for region (us-west-2):
2020/11/16 15:31:54 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-west-2)
2020/11/16 15:31:56 Sweeper Tests ran successfully:
  - aws_imagebuilder_image_recipe
2020/11/16 15:31:56 [DEBUG] Running Sweepers for region (us-east-1):
2020/11/16 15:31:56 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-east-1)
2020/11/16 15:31:57 Sweeper Tests ran successfully:
  - aws_imagebuilder_image_recipe
ok    github.com/terraform-providers/terraform-provider-aws/aws 6.199s

Output from sweeper in AWS GovCloud (US):

2020/11/16 15:32:04 [DEBUG] Running Sweepers for region (us-gov-west-1):
2020/11/16 15:32:04 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-gov-west-1)
2020/11/16 15:32:06 Sweeper Tests ran successfully:
  - aws_imagebuilder_image_recipe
ok    github.com/terraform-providers/terraform-provider-aws/aws 4.799s

# Conflicts: # aws/provider.go

…ing set on create

fixed lint issues and terminate_instance_on_failure

…vider-aws into Dogers-image-builder

…ons for aws_imagebuilder_image_recipe

Reference: #11084 Reference: #13485 Reference: #16169 (required for `aws_imagebuilder_component` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_recipe` * **New Resource:** `aws_imagebuilder_image_recipe` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImageRecipe_basic (38.20s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (35.14s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (34.64s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (33.35s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (36.82s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (35.17s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (57.27s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (35.26s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (37.01s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (35.18s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (34.55s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (34.98s) --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (31.67s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (59.07s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (19.90s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImageRecipe_basic (25.73s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (39.43s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (39.12s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (39.21s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (39.20s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (39.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (59.68s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (39.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (38.94s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (38.10s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (39.09s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (38.84s) --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (34.09s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (68.88s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (24.71s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/16 15:31:54 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/16 15:31:54 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-west-2) 2020/11/16 15:31:56 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe 2020/11/16 15:31:56 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/16 15:31:56 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-east-1) 2020/11/16 15:31:57 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe ok github.com/terraform-providers/terraform-provider-aws/aws 6.199s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/16 15:32:04 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/16 15:32:04 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-gov-west-1) 2020/11/16 15:32:06 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe ok github.com/terraform-providers/terraform-provider-aws/aws 4.799s ```

Reference: #11084 Reference: #13485 Reference: #16218 (required for `aws_imagebuilder_image_recipe` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_pipeline` * **New Resource:** `aws_imagebuilder_image_pipeline` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (36.73s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (59.17s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (28.69s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (62.02s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (61.63s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (57.56s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (61.52s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.49s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (57.93s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.29s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (62.21s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (57.90s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (73.01s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (33.95s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (45.88s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (65.03s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (39.74s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (66.42s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (63.39s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (66.54s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.28s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (66.96s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.44s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (60.45s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (81.64s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (36.13s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/18 20:23:09 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/18 20:23:09 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-west-2) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline 2020/11/18 20:23:11 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/18 20:23:11 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-east-1) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 5.138s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/18 20:23:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/18 20:23:10 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-gov-west-1) 2020/11/18 20:23:13 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 4.805s ```

gdavison

LGTM 🚀

A couple suggestions

--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (40.47s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (42.74s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (44.79s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (45.93s)
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (46.04s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (46.16s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (46.50s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (47.60s)
--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (47.78s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (47.71s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (48.71s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (48.52s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (49.01s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (55.26s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (65.64s)

gdavison · 2020-11-24T01:08:07Z

aws/data_source_aws_imagebuilder_image_recipe.go

+	if v, ok := d.GetOk("arn"); ok {
+		input.ImageRecipeArn = aws.String(v.(string))
+	}


Do we need to check, since arn is required?

Similar comment applies, I think. #16180 (comment)

aws/resource_aws_imagebuilder_image_recipe_test.go

gdavison · 2020-11-24T01:41:45Z

website/docs/r/imagebuilder_image_recipe.html.markdown

+
+The following arguments are required:
+
+* `component` - (Required) Configuration block(s) with components for the image recipe. Detailed below.


It would be helpful for "Detailed below" to be links to the block documentation

Similar comment stream applies (#16180 (comment)). We need a standard across the codebase (eventually all provider documentation in general) and using just the argument name (as done in a lot of documentation pages) does not generate unique links in the Terraform Registry currently.

Created: #16407

Co-authored-by: Graham Davison <[email protected]>

Reference: #11084 Reference: #13485 Reference: #16218 (required for `aws_imagebuilder_image_recipe` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_pipeline` * **New Resource:** `aws_imagebuilder_image_pipeline` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (36.73s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (59.17s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (28.69s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (62.02s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (61.63s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (57.56s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (61.52s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.49s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (57.93s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.29s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (62.21s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (57.90s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (73.01s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (33.95s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (45.88s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (65.03s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (39.74s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (66.42s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (63.39s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (66.54s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.28s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (66.96s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.44s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (60.45s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (81.64s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (36.13s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/18 20:23:09 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/18 20:23:09 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-west-2) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline 2020/11/18 20:23:11 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/18 20:23:11 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-east-1) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 5.138s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/18 20:23:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/18 20:23:10 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-gov-west-1) 2020/11/18 20:23:13 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 4.805s ``` Co-authored-by: Dogers <[email protected]> Co-authored-by: Jakub Kania <[email protected]> Co-authored-by: Bill Schneider <[email protected]>

ghost · 2020-11-25T21:30:49Z

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-12-24T17:10:01Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Dogers and others added 26 commits May 6, 2020 23:24

Add aws_imagebuilder_component

96b4232

Add test for data_source_aws_imagebuilder_component

2d588c2

Add aws_imagebuilder_infrastructureconfiguration

a5d9f8f

Add aws_imagebuilder_recipe

6414616

Rename to aws_imagebuilder_infrastructure_configuration

c29b5da

Fix issue with infraconfig logging

8b53767

Fix incorrect MaxItems on res

8ce7b6b

Fix S024

fbe7510

Fix AWSR002

28dfb17

Fix linting

507fe42

[#11084] Fix the imagebuilder resource, add test and docs

ca89e2b

# Conflicts: # aws/provider.go

Merge remote-tracking branch 'source/master' into image-builder

195ba8a

# Conflicts: # aws/provider.go

Merge branch 'master' into image-builder

0d050cd

# Conflicts: # aws/provider.go

Fix incorrect import on error handling

26e1bb9

Update to v2 SDK

df7016f

Fix R004 lint issue

89e7bdd

Remove changes to aws.erb

18dd1b0

Add imagebuilder_distribution_configuration

1b85e94

Add imagebuilder_image_pipeline

eb8e1ed

fixed some lint issues and fixed terminate_instance_on_failure not be…

0402fe7

…ing set on create

description can be updated in place

a20d120

Merge pull request #1 from wrschneider/image-builder

10c55b6

fixed lint issues and terminate_instance_on_failure

Merge branch 'image-builder' of ssh://github.com/Dogers/terraform-pro…

7cfe977

…vider-aws into Dogers-image-builder

service/imagebuilder: Remove non-aws_imagebuilder_image_recipe

cd14a07

service/imagebuilder: Fix incorrectly named resource files and functi…

0b2c308

…ons for aws_imagebuilder_image_recipe

bflad added new-resource Introduces a new resource. new-data-source Introduces a new data source. labels Nov 16, 2020

bflad requested a review from a team as a code owner November 16, 2020 20:59

ghost added the size/XXL Managed by automation to categorize the size of a PR. label Nov 16, 2020

ghost added provider Pertains to the provider itself, rather than any interaction with AWS. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 16, 2020

bflad added 2 commits November 16, 2020 19:48

tests/service/imagebuilder: terrafmt fixes

013f185

Merge branch 'master' into f-aws_imagebuilder_image_recipe

fea46f2

bflad added this to the v3.17.0 milestone Nov 19, 2020

bflad mentioned this pull request Nov 19, 2020

New Resource: aws_imagebuilder_image_pipeline #16299

Merged

bflad modified the milestones: v3.17.0, v3.18.0 Nov 23, 2020

gdavison approved these changes Nov 24, 2020

View reviewed changes

Update aws/resource_aws_imagebuilder_image_recipe_test.go

fae63a9

Co-authored-by: Graham Davison <[email protected]>

bflad merged commit 9b3a68d into master Nov 24, 2020

bflad deleted the f-aws_imagebuilder_image_recipe branch November 24, 2020 14:46

bflad added a commit that referenced this pull request Nov 24, 2020

Update CHANGELOG for #16218

3a10abd

This was referenced Dec 13, 2020

aws_imagebuilder_image_recipe ebs kms_key_id should allow KMS Key Aliases #16742

Closed

aws_imagebuilder_image_recipe ebs kms_key_id should allow KMS Key Aliases #16757

Closed

ghost locked as resolved and limited conversation to collaborators Dec 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: aws_imagebuilder_image_recipe #16218

New Resource: aws_imagebuilder_image_recipe #16218

bflad commented Nov 16, 2020 •

edited

Loading

gdavison left a comment

gdavison Nov 24, 2020

bflad Nov 24, 2020

gdavison Nov 24, 2020

bflad Nov 24, 2020

bflad Nov 24, 2020

ghost commented Nov 25, 2020

ghost commented Dec 24, 2020


		The following arguments are required:

		* `component` - (Required) Configuration block(s) with components for the image recipe. Detailed below.

New Resource: aws_imagebuilder_image_recipe #16218

New Resource: aws_imagebuilder_image_recipe #16218

Conversation

bflad commented Nov 16, 2020 • edited Loading

Community Note

gdavison left a comment

Choose a reason for hiding this comment

gdavison Nov 24, 2020

Choose a reason for hiding this comment

bflad Nov 24, 2020

Choose a reason for hiding this comment

gdavison Nov 24, 2020

Choose a reason for hiding this comment

bflad Nov 24, 2020

Choose a reason for hiding this comment

bflad Nov 24, 2020

Choose a reason for hiding this comment

ghost commented Nov 25, 2020

ghost commented Dec 24, 2020

bflad commented Nov 16, 2020 •

edited

Loading