r/sagemaker_notebook_instance - `lifecycle_config_name`, `root_access`, and `default_code_repository` allow updating + refactor tests #15385

DrFaust92 · 2020-09-28T21:24:04Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8880

Release note for CHANGELOG:

resource_aws_sagemaker_notebook_instance:  `lifecycle_config_name` and `root_access`  are updateable.
resource_aws_sagemaker_notebook_instance: plan time validation for `role_arn`, `instance_type`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (353.11s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (728.56s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (721.73s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (360.70s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (341.23s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (648.05s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (428.07s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (811.45s)

ewbankkit

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (375.20s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (404.47s)
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
    resource_aws_sagemaker_notebook_instance_test.go:255: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (465.30s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (540.23s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (677.81s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (686.32s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (715.37s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (738.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	738.437s

ewbankkit

Some acceptance test failures:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
    resource_aws_sagemaker_notebook_instance_test.go:152: Step 1/3 error: Error running pre-apply refresh: 2020/10/14 09:16:41 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.10.0
        
        Error: Unsupported argument
        
          on config798326402/terraform_plugin_test.tf line 19:
          19:   name          = "tf-acc-test-6054892276584607903"
        
        An argument named "name" is not expected here.
        
        
        Error: Unsupported argument
        
          on config798326402/terraform_plugin_test.tf line 20:
          20:   role_arn      = aws_iam_role.test.arn
        
        An argument named "role_arn" is not expected here.
        
        
        Error: Unsupported argument
        
          on config798326402/terraform_plugin_test.tf line 21:
          21:   instance_type = "ml.t2.medium"
        
        An argument named "instance_type" is not expected here.
        
        
        Error: Unsupported argument
        
          on config798326402/terraform_plugin_test.tf line 22:
          22:   volume_size   = 8
        
        An argument named "volume_size" is not expected here.
        
--- FAIL: TestAccAWSSagemakerNotebookInstance_volumesize (2.24s)
2020/10/14 09:16:47 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/10/14 09:16:47 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/10/14 09:16:47 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
    resource_aws_sagemaker_notebook_instance_test.go:402: Step 1/3 error: Error running apply: 2020/10/14 09:16:54 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.10.0
        
        Error: error waiting for sagemaker notebook instance (tf-acc-test-3392626168819335841) to create: unexpected state 'Failed', wanted target 'InService'. last error: %!s(<nil>)
        
        
--- FAIL: TestAccAWSSagemakerNotebookInstance_direct_internet_access (100.82s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (360.92s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (380.76s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (407.11s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (416.13s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (696.03s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (736.92s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1044.74s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1154.24s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1154.308s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

The TestAccAWSSagemakerNotebookInstance_direct_internet_access failure maybe related to recent feature?

DrFaust92 · 2020-10-14T14:31:38Z

fixing the volume test + adding logic to recreate when volume size is lowered

DrFaust92 · 2020-10-14T14:40:15Z

@ewbankkit, looking into error. If it related to the change then I think its only some type of validation. in the console a security group for outbound traffic/NAT is request. im not sure if its a recommendation or a requirement yet. hopefully a config change + docs is enough for this.

DrFaust92 · 2020-10-14T14:48:14Z

Update, I don't get an issue when creating the same thing through the console. ill see what needs to be changed in the config

DrFaust92 · 2020-10-14T19:57:33Z

added IGW for network test. passes now.

ewbankkit

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (338.80s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (370.50s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (417.09s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (443.71s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (746.39s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (756.86s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (776.17s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1016.27s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1120.82s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (1167.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1167.168s

add validation to `role_arn`, `instance_type` `lifecycle_config_name` and `root_access` change doesnt recreate. refactor tests

remove custom check funcs and replace with regular attribute checks

fix tags test add kms test add more checks

ewbankkit · 2020-10-20T16:17:29Z

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (346.66s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (360.59s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (386.54s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (397.32s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (660.18s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (744.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (876.80s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (932.05s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (935.18s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1022.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1023.054s

DrFaust92 · 2020-10-20T19:42:29Z

updated waiter:

--- PASS: TestAccAWSSagemakerNotebookInstance_kms (350.17s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (364.47s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (463.21s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1037.91s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (795.83s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1050.26s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (1096.37s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (655.68s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (358.94s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (736.94s)

YakDriver

Seems like a step backwards but capacity in commercial and GovCloud seems better.

aws/resource_aws_sagemaker_notebook_instance_test.go

Revert to t2 Co-authored-by: Dirk Avery <[email protected]>

breathingdust · 2020-10-22T15:46:04Z

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
=== CONT  TestAccAWSSagemakerNotebookInstance_update
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (352.30s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (419.12s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (476.63s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (479.74s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (778.20s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (783.59s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (802.84s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (945.62s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (965.70s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1147.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1149.089s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (336.33s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (340.61s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (349.21s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (354.04s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (594.36s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (617.10s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (637.42s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (992.65s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1011.40s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1072.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1074.820s

ghost · 2020-10-22T21:36:59Z

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-11-21T17:11:36Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added size/XL Managed by automation to categorize the size of a PR. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 28, 2020

DrFaust92 marked this pull request as ready for review September 29, 2020 15:47

DrFaust92 requested a review from a team September 29, 2020 15:47

DrFaust92 force-pushed the r/sagemaker_instance_refactor branch from 8329c46 to 7b0711a Compare September 30, 2020 07:51

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 8, 2020

ewbankkit approved these changes Oct 12, 2020

View reviewed changes

DrFaust92 changed the title ~~r/sagemaker_notebook_instance - lifecycle_config_name and root_access are updateable + refactor tests~~ r/sagemaker_notebook_instance - lifecycle_config_name, root_access, and default_code_repository allow updating + refactor tests Oct 14, 2020

DrFaust92 force-pushed the r/sagemaker_instance_refactor branch from 7b0711a to 7cac2f6 Compare October 14, 2020 11:06

ewbankkit reviewed Oct 14, 2020

View reviewed changes

DrFaust92 force-pushed the r/sagemaker_instance_refactor branch from 888475d to 8947b61 Compare October 14, 2020 19:57

DrFaust92 marked this pull request as draft October 14, 2020 20:31

DrFaust92 marked this pull request as ready for review October 14, 2020 20:35

ewbankkit approved these changes Oct 14, 2020

View reviewed changes

DrFaust92 force-pushed the r/sagemaker_instance_refactor branch from 0cd8666 to 769f6e0 Compare October 16, 2020 22:05

DrFaust92 added 10 commits October 20, 2020 17:46

move some waiters to their own package

74dc757

add validation to `role_arn`, `instance_type` `lifecycle_config_name` and `root_access` change doesnt recreate. refactor tests

standardize tags test

75bd34d

remove custom check funcs and replace with regular attribute checks

lifecycle config remove test

52a302a

fix tags test add kms test add more checks

lifecycle config remove test

fcb0495

fix tags test add kms test add more checks

fix tags test - the last one!

258ac05

fix subnet check

d1a67f3

refactor to be uniform with other tests

b46dbd6

allow updating default code repo

e145cb3

fix volume test config

1f89750

recreate instance for volume size to smaller size

ad97ba9

DrFaust92 added 6 commits October 20, 2020 17:46

really fix volume config

c69bea5

update volume fix

699523d

add igw

ee900e0

rebase

40d8bf4

fix

4c3aec5

use t3 instance for tests

9adfea2

DrFaust92 force-pushed the r/sagemaker_instance_refactor branch from d700c66 to 9adfea2 Compare October 20, 2020 14:46

DrFaust92 added 2 commits October 20, 2020 22:41

fix waiter

6d31567

remove igw

9444b73

YakDriver requested changes Oct 21, 2020

View reviewed changes

Apply suggestions from code review

e1ec08f

Revert to t2 Co-authored-by: Dirk Avery <[email protected]>

breathingdust added this to the v3.12.0 milestone Oct 22, 2020

breathingdust merged commit 181ffb0 into hashicorp:master Oct 22, 2020

breathingdust added a commit that referenced this pull request Oct 22, 2020

Update CHANGELOG.md for #15385

31a3e4d

DrFaust92 mentioned this pull request Oct 22, 2020

Feature/aws sagemaker instance update #8880

Closed

ghost locked as resolved and limited conversation to collaborators Nov 21, 2020

DrFaust92 deleted the r/sagemaker_instance_refactor branch April 15, 2021 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/sagemaker_notebook_instance - `lifecycle_config_name`, `root_access`, and `default_code_repository` allow updating + refactor tests #15385

r/sagemaker_notebook_instance - `lifecycle_config_name`, `root_access`, and `default_code_repository` allow updating + refactor tests #15385

DrFaust92 commented Sep 28, 2020 •

edited

Loading

ewbankkit left a comment

ewbankkit left a comment

DrFaust92 commented Oct 14, 2020

DrFaust92 commented Oct 14, 2020

DrFaust92 commented Oct 14, 2020

DrFaust92 commented Oct 14, 2020

ewbankkit left a comment

ewbankkit commented Oct 20, 2020

DrFaust92 commented Oct 20, 2020

YakDriver left a comment

breathingdust commented Oct 22, 2020

ghost commented Oct 22, 2020

ghost commented Nov 21, 2020

r/sagemaker_notebook_instance - lifecycle_config_name, root_access, and default_code_repository allow updating + refactor tests #15385

r/sagemaker_notebook_instance - lifecycle_config_name, root_access, and default_code_repository allow updating + refactor tests #15385

Conversation

DrFaust92 commented Sep 28, 2020 • edited Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

DrFaust92 commented Oct 14, 2020

DrFaust92 commented Oct 14, 2020

DrFaust92 commented Oct 14, 2020

DrFaust92 commented Oct 14, 2020

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Oct 20, 2020

DrFaust92 commented Oct 20, 2020

YakDriver left a comment

Choose a reason for hiding this comment

breathingdust commented Oct 22, 2020

ghost commented Oct 22, 2020

ghost commented Nov 21, 2020

r/sagemaker_notebook_instance - `lifecycle_config_name`, `root_access`, and `default_code_repository` allow updating + refactor tests #15385

r/sagemaker_notebook_instance - `lifecycle_config_name`, `root_access`, and `default_code_repository` allow updating + refactor tests #15385

DrFaust92 commented Sep 28, 2020 •

edited

Loading