Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_workflow - add tagging support + arn + max concurrent runs #14910

Merged
merged 5 commits into from
Sep 23, 2020
Merged

r/glue_workflow - add tagging support + arn + max concurrent runs #14910

merged 5 commits into from
Sep 23, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 29, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13826
Closes #14994

Release note for CHANGELOG:

resource_aws_glue_workflow - add `tags` argument
resource_aws_glue_workflow - add `arn` attribute
resource_aws_glue_workflow - add `max_concurrent_runs` argument
resource_aws_glue_workflow - plan time validation for `name`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueWorkflow_'
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (44.11s)
--- PASS: TestAccAWSGlueWorkflow_Description (80.65s)
--- PASS: TestAccAWSGlueWorkflow_Tags (103.40s)
--- PASS: TestAccAWSGlueWorkflow_disappears (30.25s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (107.44s)

@DrFaust92 DrFaust92 requested a review from a team August 29, 2020 19:27
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 29, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 29, 2020
@DrFaust92 DrFaust92 mentioned this pull request Sep 2, 2020
Closed
ewbankkit
ewbankkit reviewed Sep 22, 2020
View reviewed changes
aws/resource_aws_glue_workflow.go

input := &glue.GetWorkflowInput{
Name: aws.String(d.Id()),
}

log.Printf("[DEBUG] Reading Glue Workflow: %s", input)
log.Printf("[DEBUG] Reading Glue Workflow: %#v", input)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we prefer %s as the AWS SDK generates .String() methods.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used this notation previously (as i've seen in being used somewhere in the provider) and this was previously approved. so idk? i dont really mind which.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change then.

ewbankkit
ewbankkit approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueWorkflow_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueWorkflow_ -timeout 120m
=== RUN   TestAccAWSGlueWorkflow_basic
=== PAUSE TestAccAWSGlueWorkflow_basic
=== RUN   TestAccAWSGlueWorkflow_maxConcurrentRuns
=== PAUSE TestAccAWSGlueWorkflow_maxConcurrentRuns
=== RUN   TestAccAWSGlueWorkflow_DefaultRunProperties
=== PAUSE TestAccAWSGlueWorkflow_DefaultRunProperties
=== RUN   TestAccAWSGlueWorkflow_Description
=== PAUSE TestAccAWSGlueWorkflow_Description
=== RUN   TestAccAWSGlueWorkflow_Tags
=== PAUSE TestAccAWSGlueWorkflow_Tags
=== RUN   TestAccAWSGlueWorkflow_disappears
=== PAUSE TestAccAWSGlueWorkflow_disappears
=== CONT  TestAccAWSGlueWorkflow_basic
=== CONT  TestAccAWSGlueWorkflow_Description
=== CONT  TestAccAWSGlueWorkflow_disappears
=== CONT  TestAccAWSGlueWorkflow_DefaultRunProperties
=== CONT  TestAccAWSGlueWorkflow_Tags
=== CONT  TestAccAWSGlueWorkflow_maxConcurrentRuns
=== CONT  TestAccAWSGlueWorkflow_disappears
    resource_aws_glue_workflow_test.go:230: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueWorkflow_disappears (22.96s)
--- PASS: TestAccAWSGlueWorkflow_basic (32.73s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (33.19s)
--- PASS: TestAccAWSGlueWorkflow_Description (47.56s)
--- PASS: TestAccAWSGlueWorkflow_Tags (59.36s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (60.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.945s

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSGlueWorkflow_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueWorkflow_ -timeout 120m
=== RUN   TestAccAWSGlueWorkflow_basic
=== PAUSE TestAccAWSGlueWorkflow_basic
=== RUN   TestAccAWSGlueWorkflow_maxConcurrentRuns
=== PAUSE TestAccAWSGlueWorkflow_maxConcurrentRuns
=== RUN   TestAccAWSGlueWorkflow_DefaultRunProperties
=== PAUSE TestAccAWSGlueWorkflow_DefaultRunProperties
=== RUN   TestAccAWSGlueWorkflow_Description
=== PAUSE TestAccAWSGlueWorkflow_Description
=== RUN   TestAccAWSGlueWorkflow_Tags
=== PAUSE TestAccAWSGlueWorkflow_Tags
=== RUN   TestAccAWSGlueWorkflow_disappears
=== PAUSE TestAccAWSGlueWorkflow_disappears
=== CONT  TestAccAWSGlueWorkflow_basic
=== CONT  TestAccAWSGlueWorkflow_Tags
=== CONT  TestAccAWSGlueWorkflow_disappears
=== CONT  TestAccAWSGlueWorkflow_DefaultRunProperties
=== CONT  TestAccAWSGlueWorkflow_Description
=== CONT  TestAccAWSGlueWorkflow_maxConcurrentRuns
=== CONT  TestAccAWSGlueWorkflow_disappears
    resource_aws_glue_workflow_test.go:230: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueWorkflow_disappears (13.11s)
--- PASS: TestAccAWSGlueWorkflow_basic (17.40s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (17.43s)
--- PASS: TestAccAWSGlueWorkflow_Description (27.43s)
--- PASS: TestAccAWSGlueWorkflow_Tags (43.07s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (51.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.947s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSGlueWorkflow_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueWorkflow_ -timeout 120m
=== RUN   TestAccAWSGlueWorkflow_basic
=== PAUSE TestAccAWSGlueWorkflow_basic
=== RUN   TestAccAWSGlueWorkflow_maxConcurrentRuns
=== PAUSE TestAccAWSGlueWorkflow_maxConcurrentRuns
=== RUN   TestAccAWSGlueWorkflow_DefaultRunProperties
=== PAUSE TestAccAWSGlueWorkflow_DefaultRunProperties
=== RUN   TestAccAWSGlueWorkflow_Description
=== PAUSE TestAccAWSGlueWorkflow_Description
=== RUN   TestAccAWSGlueWorkflow_Tags
=== PAUSE TestAccAWSGlueWorkflow_Tags
=== RUN   TestAccAWSGlueWorkflow_disappears
=== PAUSE TestAccAWSGlueWorkflow_disappears
=== CONT  TestAccAWSGlueWorkflow_basic
=== CONT  TestAccAWSGlueWorkflow_Tags
=== CONT  TestAccAWSGlueWorkflow_disappears
=== CONT  TestAccAWSGlueWorkflow_DefaultRunProperties
=== CONT  TestAccAWSGlueWorkflow_Description
=== CONT  TestAccAWSGlueWorkflow_maxConcurrentRuns
=== CONT  TestAccAWSGlueWorkflow_disappears
    resource_aws_glue_workflow_test.go:230: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueWorkflow_disappears (11.91s)
--- PASS: TestAccAWSGlueWorkflow_basic (14.65s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (17.82s)
--- PASS: TestAccAWSGlueWorkflow_Description (27.70s)
--- PASS: TestAccAWSGlueWorkflow_Tags (37.83s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (47.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.918s

@breathingdust breathingdust added this to the v3.8.0 milestone Sep 23, 2020
@breathingdust breathingdust merged commit 867ae3b into hashicorp:master Sep 23, 2020
breathingdust added a commit that referenced this pull request Sep 23, 2020
@breathingdust
Update CHANGELOG.md for #14910
4294d99
@DrFaust92 DrFaust92 deleted the r/workflow_tags branch September 23, 2020 20:41
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

Support for Glue Workflow Max Concurrency
3 participants
@DrFaust92 @breathingdust @ewbankkit