Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cloudwatch_log_metric_filter's metric_transformation block missing optional defaultValue #1442

Closed
endemics opened this issue Aug 17, 2017 · 1 comment · Fixed by #1578
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@endemics
Copy link

Hi,

Please consider adding the possibility to set the defaultValue to aws_cloudwatch_log_metric_filter's metric_transformation block

Terraform Version

terraform 0.10.0 with aws plugin 0.1.4

Affected Resource(s)

aws_cloudwatch_log_metric_filter

Expected Behavior

Cloudwatchlog metric filter as currently implemented in terraform aws plugin 0.1.4 does not support default values in the metric_transformation block.

As per the API reference, it is possible to specify an optional defaultValue to a metric filter

Specifying a default value ensures that data is reported even during periods when no log events occur, preventing spotty metrics where data sometimes does not exist.

(ref http://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CountingLogEventsExample.html)

The go sdk supports the DefaultValue in the type MetricTransformation struct, but it is absent from terraform's resourceAwsCloudWatchLogMetricFilter()

@apparentlymart apparentlymart added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 17, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
2 participants