Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand functionality of data.aws_workspaces_bundle to do local filtering #12496

Closed
thatderek opened this issue Mar 21, 2020 · 2 comments · Fixed by #12497
Closed

Expand functionality of data.aws_workspaces_bundle to do local filtering #12496

thatderek opened this issue Mar 21, 2020 · 2 comments · Fixed by #12497
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service.
Milestone

Comments

@thatderek
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently, the data lookup for aws_workspaces_bundle only allows for lookup by bundle-id. However, as bundle-id is almost always the attribute required (by @Tensho's work in #11608 for instance) it would be way more helpful to have a lookup that could filter on owner/name/maybe more.

As it stands, the sdk only allows filtering by owner and further filtering would need to be done locally, post call to the aws api.

New or Affected Resource(s)

  • data.aws_workspaces_bundle

Potential Terraform Configuration

data "aws_workspaces_bundle" "main" { 
  owner = "AMAZON"
  name  = "Value with Windows 10 and Office 2016"
}

References

@thatderek thatderek added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 21, 2020
@ghost ghost added the service/workspaces Issues and PRs that pertain to the workspaces service. label Mar 21, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2020
@gdavison gdavison added this to the v2.67.0 milestone Jun 18, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 19, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants