Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wd.Setenv and wd.Unsetenv #684

Closed
kmoe opened this issue Sep 7, 2020 · 2 comments · Fixed by #913
Closed

Remove wd.Setenv and wd.Unsetenv #684

kmoe opened this issue Sep 7, 2020 · 2 comments · Fixed by #913
Assignees
@bflad
Labels
subsystem/tests Issues and feature requests related to the testing framework.
Milestone
v2.13.0

Comments

@kmoe
Copy link
Member

kmoe commented Sep 7, 2020

These are not used in the SDK. Are they used anywhere else? If not, remove them.

This is a breaking change.
@kmoe kmoe transferred this issue from hashicorp/terraform-plugin-test Jan 12, 2021
@bflad
Copy link
Contributor

bflad commented Mar 16, 2022

Looks like we have one usage in helper/resource: wd.Setenv("CHECKPOINT_DISABLE", "1") -- we can likely hardcode that differently so its still propagated to terraform-exec.

@bflad bflad added the subsystem/tests Issues and feature requests related to the testing framework. label Mar 16, 2022
@bflad bflad self-assigned this Mar 16, 2022
@bflad bflad modified the milestones: v2.12.0, v2.13.0 Mar 16, 2022
bflad added a commit that referenced this issue Mar 23, 2022
@bflad
internal/plugintest: Set CHECKPOINT_DISABLE=1 in terraform-exec directly
79c10eb 
Reference: #684
@bflad bflad mentioned this issue Mar 23, 2022
Merged
bflad added a commit that referenced this issue Mar 28, 2022
@bflad
internal/plugintest: Set CHECKPOINT_DISABLE=1 in terraform-exec direc…
1c932cf 
…tly (#913)

Reference: #684
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
subsystem/tests Issues and feature requests related to the testing framework.
Projects
None yet
Milestone
v2.13.0
2 participants
@bflad @kmoe