helper/resource: Set CHECKPOINT_DISABLE environment variable outside terraform-exec #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terraform-exec Reference: #935 When using `(tfexec.Terraform).SetEnv()`, it will no longer copy `os.Environ()`. It is also not possible for the code to call `tfexec.CleanEnv(os.Environ())` with the additional environment variable as it would strip previously accepted `TF_VAR_` environment variables. There are no plans to change this behavior in terraform-exec.
detro
approved these changes
Apr 12, 2022
bflad
added a commit
that referenced
this pull request
Apr 12, 2022
bflad
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Apr 13, 2022
Reference: hashicorp/terraform-plugin-sdk#935 With github.com/hashicorp/terraform-plugin-sdk/[email protected]: ```console $ TF_ACC=1 go test -count=1 -run='TestAccFrameworkResourceUser_TF_VAR_Environment_Variable' -v ./internal/frameworkprovider/ === RUN TestAccFrameworkResourceUser_TF_VAR_Environment_Variable resource_user_test.go:117: Step 1/1 error: Error running pre-apply refresh: variable "framework_user_name" was required but not supplied --- FAIL: TestAccFrameworkResourceUser_TF_VAR_Environment_Variable (0.56s) FAIL FAIL github.com/hashicorp/terraform-provider-corner/internal/frameworkprovider 1.324s FAIL ``` Passes with hashicorp/terraform-plugin-sdk#937.
bflad
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Apr 15, 2022
Reference: hashicorp/terraform-plugin-sdk#935 With github.com/hashicorp/terraform-plugin-sdk/[email protected]: ```console $ TF_ACC=1 go test -count=1 -run='TestAccFrameworkResourceUser_TF_VAR_Environment_Variable' -v ./internal/frameworkprovider/ === RUN TestAccFrameworkResourceUser_TF_VAR_Environment_Variable resource_user_test.go:117: Step 1/1 error: Error running pre-apply refresh: variable "framework_user_name" was required but not supplied --- FAIL: TestAccFrameworkResourceUser_TF_VAR_Environment_Variable (0.56s) FAIL FAIL github.com/hashicorp/terraform-provider-corner/internal/frameworkprovider 1.324s FAIL ``` Passes with hashicorp/terraform-plugin-sdk#937.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #935
When using
(tfexec.Terraform).SetEnv(), it will no longer copyos.Environ(). It is also not possible for the code to calltfexec.CleanEnv(os.Environ())with the additional environment variable as it would strip previously acceptedTF_VAR_environment variables. There are no plans to change this behavior in terraform-exec.