Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose provider metadata #345

Closed
paddycarver opened this issue Mar 7, 2020 · 2 comments
Closed

Expose provider metadata #345

paddycarver opened this issue Mar 7, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@paddycarver
Copy link
Contributor

Now that hashicorp/terraform#22583 has been merged, we need to surface the new protocol information. I'm inclined to do it using the ResourceData, as it is in the PR, but I think the open question is whether the method on ResourceData takes a pointer and unmarshals the cty into it, or whether the ResourceData method returns the cty.Value and the gocty package is used to turn it into a Go struct directly. The benefits of accepting the pointer is the gocty dependency is hidden a bit and users don't need to know or think about it. The benefits of returning the cty.Value type is it's more flexible. See also #261.

@paddycarver
Copy link
Contributor Author

Resolved by #405

@ghost
Copy link

ghost commented May 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant