You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that hashicorp/terraform#22583 has been merged, we need to surface the new protocol information. I'm inclined to do it using the ResourceData, as it is in the PR, but I think the open question is whether the method on ResourceData takes a pointer and unmarshals the cty into it, or whether the ResourceData method returns the cty.Value and the gocty package is used to turn it into a Go struct directly. The benefits of accepting the pointer is the gocty dependency is hidden a bit and users don't need to know or think about it. The benefits of returning the cty.Value type is it's more flexible. See also #261.
The text was updated successfully, but these errors were encountered:
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
ghost
locked and limited conversation to collaborators
May 31, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Now that hashicorp/terraform#22583 has been merged, we need to surface the new protocol information. I'm inclined to do it using the ResourceData, as it is in the PR, but I think the open question is whether the method on ResourceData takes a pointer and unmarshals the cty into it, or whether the ResourceData method returns the cty.Value and the gocty package is used to turn it into a Go struct directly. The benefits of accepting the pointer is the gocty dependency is hidden a bit and users don't need to know or think about it. The benefits of returning the cty.Value type is it's more flexible. See also #261.
The text was updated successfully, but these errors were encountered: