-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the workspace show
command
#245
Conversation
workspace show
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, my only one reservation is that we aim to also more gracefully handle version differences in tfexec and this command in particular was introduced in v0.10
hashicorp/terraform@9d7fce2
Would you therefore mind adding a version check, similar to the one we have for fmt
here?
Lines 129 to 132 in 750bc90
err := tf.compatible(ctx, tf0_7_7, nil) | |
if err != nil { | |
return nil, fmt.Errorf("fmt was first introduced in Terraform 0.7.7: %w", err) | |
} |
FYI There's a more long-term issue tracking this problem for all commands #121
excellent point! i've added a version check for this command and a little bit of extra testing :] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds support for the
workspace show
command.Closes #239
Related links