Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump terraform-json to 0.13.0 #224

Merged
merged 2 commits into from
Oct 5, 2021
Merged

deps: Bump terraform-json to 0.13.0 #224

merged 2 commits into from
Oct 5, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 1, 2021

I wanted to add tests for the new v1 format, but the relevant PR was not merged yet, so I just left a TODO in the appropriate places and the existing tests should fail when we bump Latest_v1_1 - so we can cross the bridge when we get to it.

cc @alisdair


This brings in a bug fix for a panic: hashicorp/terraform-json#44 which is the main motivation for the bump here.


I have prepared a draft PR #226 with the necessary changes accounting for JSON format changes in TF 1.1.

@radeksimko radeksimko requested a review from kmoe October 1, 2021 15:21
@radeksimko radeksimko marked this pull request as ready for review October 1, 2021 15:21
@radeksimko radeksimko added the bug Something isn't working label Oct 4, 2021
@radeksimko radeksimko merged commit e4d3728 into main Oct 5, 2021
@radeksimko radeksimko deleted the deps-json-bump branch October 5, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants