Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add providers lock Command #203

Merged

Conversation

philnielsen
Copy link
Contributor

Adds feature requested in #201. This allows programatic generation of.terraform.lock.hcl files via this libary.

Adds feature requested in hashicorp#201. This allows programatic generation of
`.terraform.lock.hcl` files via this library
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 28, 2021

CLA assistant check
All committers have signed the CLA.

@philnielsen
Copy link
Contributor Author

@radeksimko this is a follow up to #201 that i've finally gotten a chance to work on.

@radeksimko radeksimko self-requested a review July 29, 2021 07:26
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

Aside from my in-line comments it looks good!

tfexec/providers_lock.go Outdated Show resolved Hide resolved
tfexec/options.go Outdated Show resolved Hide resolved
tfexec/options.go Outdated Show resolved Hide resolved
tfexec/options.go Outdated Show resolved Hide resolved
tfexec/providers_lock.go Outdated Show resolved Hide resolved
This command was added in 0.14 so it should helpfully error out if used
with a version before that. Also cleaned up some godoc comments per PR
feedback.
@philnielsen philnielsen requested a review from radeksimko August 3, 2021 20:20
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@radeksimko radeksimko merged commit 300b7ea into hashicorp:main Aug 4, 2021
@philnielsen philnielsen deleted the philnielsen/add-providers-lock-cmd branch August 4, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants