Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for the terraform 0.12upgrade command #105

Merged
merged 6 commits into from
Nov 27, 2020

Conversation

gdavison
Copy link
Contributor

Adds support for the terraform 0.12upgrade command

@radeksimko
Copy link
Member

👋 Hey Graham,
What is the intended use case for this command?

In general terraform-exec is used for automation (i.e. usually unattended execution) and from what I can tell the upgrade commands are not intended to be used in a "fire & forget" way, because there are no guarantees that the upgraded config will be actually usable and it may require further manual changes.

@gdavison
Copy link
Contributor Author

I'm using it for an enhancement to https://github.com/katbyte/terrafmt. It would allow users to apply terraform 0.12 to any terraform blocks in Markdown or Go files.

Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The use case is valid and the implementation sound. Thanks for including a unit test.

Happy to merge when an end-to-end test is added. There's a section in CONTRIBUTING.md describing how to do this. If you don't have time, please let me know and I'll be happy to add it.

Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmoe kmoe merged commit 1bb2098 into hashicorp:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants