Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update changelog to include list runs query parameters #73

Merged
merged 3 commits into from
Jul 21, 2022
Merged

update changelog to include list runs query parameters #73

merged 3 commits into from
Jul 21, 2022
+1 −0

Conversation

mjyocca
Copy link
Contributor

@mjyocca mjyocca commented Jul 19, 2022 •
edited
Loading

Why

Updating changelog to include api doc changes for List runs

Related PR #44

Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • N/A One or more labels describe the type of change (e.g. clarification) and associated product (e.g. tfc).
  • Description links to related pull requests or issues, if any.

Content

  • N/A Redirects have been added for moved, renamed, or deleted pages. This requires a separate PR in the terraform-website repository redirects.next.js file.
  • API documentation and the API Changelog have been updated.
  • N/A Links to related content where appropriate (e.g., API endpoints, permissions, etc.).
  • N/A Pages with related content are updated and link to this content when appropriate.
  • N/A Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages.
  • N/A New pages have metadata (page name and description) at the top.
  • N/A New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility.
  • N/A New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars.
  • N/A UI elements (button names, page names, etc.) are bolded.
  • [] The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

@mjyocca mjyocca requested a review from laurapacilio July 19, 2022 19:12
@vercel
Copy link

vercel bot commented Jul 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
terraform-docs-common ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 8:57PM (UTC)

laurapacilio
laurapacilio approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one nit - thank you for fixing this in the changelog!! :)

website/docs/cloud-docs/api-docs/changelog.mdx Outdated Show resolved Hide resolved
@mjyocca
Copy link
Contributor Author

mjyocca commented Jul 21, 2022

@laurapacilio no problem, and thank you! I'll know for next time to include the changes.

@mjyocca mjyocca merged commit 33b992f into main Jul 21, 2022
@mjyocca mjyocca deleted the mjyocca/update-list-runs-changelog branch July 21, 2022 21:00
hashibot-web added a commit that referenced this pull request May 16, 2023
@hashibot-web
Merge pull request #73 from hashicorp/repo-sync
a73926b 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurapacilio laurapacilio laurapacilio approved these changes

Assignees
No one assigned
Labels
tw-reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjyocca @laurapacilio