Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(provider-generator): verify generated provider emit same HCL across languages #1311

Merged
merged 11 commits into from
Dec 9, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

By providing a custom JSON schema we can build edge cases specific to our project

Closes #1207

@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch 3 times, most recently from 006c243 to cde5b00 Compare November 26, 2021 16:00
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review November 26, 2021 16:17
@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch from cde5b00 to c662f47 Compare November 26, 2021 16:17
@DanielMSchmidt DanielMSchmidt changed the title test(provider-generation): verify generated provider emit same HCL across languages test(provider-generator): verify generated provider emit same HCL across languages Nov 26, 2021
@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch from c662f47 to f351941 Compare November 26, 2021 16:23
@ansgarm
Copy link
Member

ansgarm commented Nov 29, 2021

Builds fail due to: jestjs/jest#12098

@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch 3 times, most recently from a424fb4 to 7f6694d Compare December 2, 2021 10:44
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to get a high level overview of how that's working in the PR description and / or one of the Readmes (not sure which one would be the right place).

Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to get a high level overview of how that's working in the PR description and / or one of the Readmes (not sure which one would be the right place).

@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch from fbb5b3d to 5af34e7 Compare December 6, 2021 10:59
@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch from c8d57c8 to 622832e Compare December 9, 2021 11:52
@DanielMSchmidt DanielMSchmidt force-pushed the provider-generation-jsii-test branch from 622832e to 199167e Compare December 9, 2021 13:22
@DanielMSchmidt DanielMSchmidt merged commit 73a8394 into main Dec 9, 2021
@DanielMSchmidt DanielMSchmidt deleted the provider-generation-jsii-test branch December 9, 2021 14:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test provider generation with jsii
3 participants