-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): Pre-releases should use next version #1257
chore(release): Pre-releases should use next version #1257
Conversation
Yep. |
6c0d2e1
to
458e3dc
Compare
I've been doing some testing here: https://github.com/jsteinich/standard-version-test I think that I've run into conventional-changelog/standard-version#724 as everything worked for the 1st pre-release, but failed on the next one. |
I did some more investigation and managed to get things working. I'm not going to update the release instructions quite yet since the release changelog generation hasn't been fully tested yet. I figure we can try it out with the next release and compare to the existing script. Since that is a secondary goal, if it doesn't work we can just not use it and continue iterating or remove. |
Seems to work as expected:
Is there anything else missing or would you consider this as good to go @jsteinich ? |
@skorfmann I think it is good to go. |
chore(release): Revert "Merge pull request #1257 from jsteinich/pre_release_version_n…
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This takes care of the main part of #561. Also includes some tools to help with #656.
Using standard-version to handle bumping the version number in a manner similar to semantic-release but without the release.
Can run
yarn prepare-release
oryarn prepare-release --release-as minor
when preparing for an actual release to bump the version and generate the changelog.Follow up:
We also discussed changing the qualifier. For at least Java that would probably be a good idea; however, there isn't an easy way to change for just 1 language. Probably makes sense to hold off on any changes until we get actual user feedback requesting changes.