fix(cli): fix bug that required cdktf.json in parent directory when running convert #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
fix-convert-cdktf-json-detection
branch
from
bc8fb93 to
a6026e9
Compare
…unning convert `path.resolve(rootPath, ..)` will return rootPath if there's no more parent directory. This caused an infinite loop ending in `RangeError: Maximum call stack size exceeded`. Resolves #1247
ansgarm
force-pushed
the
fix-convert-cdktf-json-detection
branch
2 times, most recently
from
1b31840 to
b90d17d
Compare
increase test timeout as well
ansgarm
force-pushed
the
fix-convert-cdktf-json-detection
branch
from
c5ace43 to
661421b
Compare
skorfmann
approved these changes
Nov 5, 2021
DanielMSchmidt
approved these changes
Nov 5, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.resolve(rootPath, ..)will return rootPath if there's no more parent directory.This caused an infinite loop ending in
RangeError: Maximum call stack size exceeded.Resolves #1247