Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): test generated providers #1235

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

This PR adds a couple of usage tests to the providers integration tests. These are aimed to find behaviour that should be working but is broken in regards to using the generated resources. We want to test mutation, references, and namespaces here.

@DanielMSchmidt DanielMSchmidt force-pushed the improve-provider-generation-tests branch 5 times, most recently from aad7898 to 26ba40d Compare November 2, 2021 16:56
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review November 2, 2021 16:57
test/test-helper.ts Outdated Show resolved Hide resolved
test/test-helper.ts Outdated Show resolved Hide resolved
test/test-helper.ts Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the improve-provider-generation-tests branch 3 times, most recently from c2c7920 to d254a85 Compare November 3, 2021 15:03
test/test-helper.ts Outdated Show resolved Hide resolved
test/typescript/providers/test.ts Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the improve-provider-generation-tests branch from 956545d to e8d6d71 Compare November 3, 2021 16:15
ansgarm
ansgarm previously requested changes Nov 3, 2021
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just came to my mind: A draft for release notes would be nice. Some that mention .toString() being required when using Snapshot tests.

@ansgarm ansgarm dismissed their stale review November 4, 2021 09:38

It was no user facing change, whoops

@DanielMSchmidt DanielMSchmidt force-pushed the improve-provider-generation-tests branch from e8d6d71 to 5fab300 Compare November 4, 2021 09:50
@DanielMSchmidt DanielMSchmidt merged commit 258d373 into main Nov 4, 2021
@DanielMSchmidt DanielMSchmidt deleted the improve-provider-generation-tests branch November 4, 2021 10:08
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants