Laura edits 987 #1080
Merged
Laura edits 987 #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorfmann
approved these changes
Sep 27, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @skorfmann!
I was talking to @schersh, and she was mentioning how you both discussed how it's odd to talk about outputs in isolation. She and I discussed the idea of combining a few of the related concepts pages into a single page....so what do you both think about this? It puts Input Variables, Local Values, and Output Values onto one page called "Variables and Outputs." The Terraform documentation groups these topics this way as well, so I thought maybe it'd be nice parallelism?
I made the new page, adjusted the sidebar, and did a bit of work on structuring the page. But I didn't do a super thorough copyedit yet because I wanted to see what you both think of this approach before moving forward. If we like it, maybe you can merge it into your original PR @skorfmann, you can work on the copy a bit more, and then Sarah and I can do the copyedit on that one?
Thank you both :-)