unknown type set(string)

[hd-deman]

Module generation fails if it contains variables with type = set(string).

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

terraform-cdk: 0.5.0

Debug Output

❯ cdktf get

Error: Internal Error: unknown type set(string)
    at Object.Internal (/usr/local/lib/node_modules/cdktf-cli/lib/errors.js:20:21)
    at parseType (/usr/local/lib/node_modules/cdktf-cli/lib/get/generator/module-generator.js:104:27)
    at ModuleGenerator.emitSubmodule (/usr/local/lib/node_modules/cdktf-cli/lib/get/generator/module-generator.js:38:91)
    at new ModuleGenerator (/usr/local/lib/node_modules/cdktf-cli/lib/get/generator/module-generator.js:12:18)
    at ConstructsMaker.generateTypeScript (/usr/local/lib/node_modules/cdktf-cli/lib/get/constructs-maker.js:186:13)
    at async ConstructsMaker.generate (/usr/local/lib/node_modules/cdktf-cli/lib/get/constructs-maker.js:190:9)
    at async get (/usr/local/lib/node_modules/cdktf-cli/bin/cmds/ui/get.js:50:17) {
  type: 'set(string)'
}
⠏ downloading and generating modules and providers...
Internal Error: unknown type set(string)

Expected Behavior

It should generate a module which use type set(string) in the variables.

Actual Behavior

It fails on cdktf get command.

Steps to Reproduce

Just add module with type set(string) (https://github.com/terraform-aws-modules/terraform-aws-iam/tree/master/modules/iam-assumable-role-with-oidc in this example) to cdktf.json

{
...
  "terraformModules": ["terraform-aws-modules/iam/aws//modules/[email protected]"],
...
}

[jsteinich]

Caused by

terraform-cdk/packages/cdktf-cli/lib/get/generator/module-generator.ts

Line 136 in a8692c7

const complex = /^(object|list|map)\(([\s\S]+)\)/;

not matching set and no case for it farther down.

Set is also not fully supported in general since jsii doesn't support them (aws/jsii#1). Could be worked around, possibly with ideas from #424.

[LumaKernel]

Any workaround for this today like .addOverride()? I tried to use TerraformModule but this is abstract class.

[LumaKernel]

I can use TerraformHclModule and cdktf synth + tf init, followed by tf command itself.

[jsteinich]

@LumaKernel glad that you were able to find that workaround. As the issue occurs during code generation, that's really the only way currently.

Out of curiosity, why are you running tf directly after synthing?

[LumaKernel]

At that time I got the error and I felt the change to tf command itself solved my problem, but now I checked it and it works. ( no version up ). I don't remember was it dream or not but if I get it again, I'll write it down.
Thank you.

EDIT: Ah, it may not be solved, or I am getting new problem with cdktf without tf. But it's not relevant to this issue. Shortly cdktf deploy ≒ tf apply and tf plan && tf apply are producing differently. If I can make short repro, I'll make a new issue.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.