Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JSII automatically #1206

Closed
skorfmann opened this issue Oct 25, 2021 · 5 comments · Fixed by #1336
Closed

Upgrade JSII automatically #1206

skorfmann opened this issue Oct 25, 2021 · 5 comments · Fixed by #1336
Assignees
@ansgarm
Labels
enhancement New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/small estimated < 1 day upstream/jsii Pending upstream work on JSII
Milestone
0.8

Comments

@skorfmann
Copy link
Contributor

In order to see issues with new jsii releases as early as possible, we'll have to have an auto-upgrade workflow which takes care of this.
@skorfmann skorfmann added enhancement New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Oct 25, 2021
@skorfmann skorfmann added this to the 0.8 (in planning) milestone Oct 25, 2021
@ansgarm ansgarm self-assigned this Oct 27, 2021
@phinze phinze added the size/small estimated < 1 day label Nov 9, 2021
@DanielMSchmidt
Copy link
Contributor

Isn't this already done by Dependabot?

@DanielMSchmidt DanielMSchmidt added the upstream/jsii Pending upstream work on JSII label Nov 16, 2021
@DanielMSchmidt
Copy link
Contributor

No, we first need to unblock that JSII can be upgraded (with the python issues)

@ansgarm
Copy link
Member

ansgarm commented Nov 16, 2021

Right – but then it'll be done by Dependabot 👍

@DanielMSchmidt
Copy link
Contributor

Lots of snapshots have the JSII version and other info related to a specific JSII version in it. To have successful Dependabot merges we need to remove these parts from the snapshot. We need to make a small change here to how we write the snapshots / what we test.

@ansgarm ansgarm mentioned this issue Nov 22, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ansgarm ansgarm

Labels
enhancement New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/small estimated < 1 day upstream/jsii Pending upstream work on JSII
Projects
None yet
Milestone
0.8
4 participants
@phinze @skorfmann @ansgarm @DanielMSchmidt