config: importing resources @ 2015-11-01
#4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a curious choice so it's worth some context. The Key Vaults List endpoint appears to have a series of caching issues, where the cache is only appended to/removed from, rather than being updated/invalidated upon changes happening. This means that it's possible for the cache to become outdated and contain a limited subset of Resources - as in our case this is currently returning only 2 of 10 provisioned Key Vaults. Whilst that's arguably worth a bug report to the API, checking the Azure CLI's implementation, the command `az keyvault list` performs two queries: 1. `/subscriptions/XXX/resources?$filter=resourceType%20eq%20%27Microsoft.KeyVault%2Fvaults%27&api-version=2015-11-01` 2. `/subscriptions/XXX/providers/Microsoft.KeyVault/managedHSMs?api-version=2023-07-01` This means that the Azure CLI itself isn't using the Key Vault List endpoint and for the life of me I can't find an explanation as to the why - so in lieu of any other options, we're going to use same older API version as the Azure CLI and populate the cache in the AzureRM Provider using both the List on the Resource Type endpoint and a List on the Resources endpoint. I'd rather not use an API version this old when a newer one is available - but the Azure CLI has opted to do so, so there must be a reason for it - I would assume there's no cache on this API Version, but I can't (easily) confirm that. So this'll have to do.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
May 23, 2024
…t and the Resources Endpoint This commit: 1. Registers a client for Resources@2015-11-01 and KeyVault@2023-07-01 2. Updates the caching to retrieve the list of Key Vaults using both the List API for the ResourceType and using the Resources API directly - meaning we have a more up-to-date set of data. Notably we're using the older Resources API that the Azure CLI uses, more details can be found in hashicorp/pandora#4148 however by loading both we're hoping to alleviate the caching issues we've seen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a curious choice so it's worth some context.
The Key Vaults List endpoint appears to have a series of caching issues, where the cache is only appended to/removed from, rather than being updated/invalidated upon changes happening. This means that it's possible for the cache to become outdated and contain a limited subset of Resources - as in our case this is currently returning only 2 of 10 provisioned Key Vaults.
Whilst that's arguably worth a bug report to the API, checking the Azure CLI's implementation, the command
az keyvault listperforms two queries:/subscriptions/XXX/resources?$filter=resourceType%20eq%20%27Microsoft.KeyVault%2Fvaults%27&api-version=2015-11-01/subscriptions/XXX/providers/Microsoft.KeyVault/managedHSMs?api-version=2023-07-01This means that the Azure CLI itself isn't using the Key Vault List endpoint and for the life of me I can't find an explanation as to the why - so in lieu of any other options, we're going to use same older API version as the Azure CLI and populate the cache in the AzureRM Provider using both the List on the Resource Type endpoint and a List on the Resources endpoint.
I'd rather not use an API version this old when a newer one is available - but the Azure CLI has opted to do so, so there must be a reason for it - I would assume there's no cache on this API Version, but I can't (easily) confirm that. So this'll have to do.