Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config - add Chaos Studio Target resource definition #3671

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

stephybun
Copy link
Member

This PR adds the resource definition for Chaos Studio Target which will be a partially generated resource.

This is dependent on hashicorp/terraform-provider-azurerm#24580

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments inline but this otherwise LGTM 👍

docs/resource-manager-generate-new-resource.md Outdated Show resolved Hide resolved
docs/resource-manager-generate-new-resource.md Outdated Show resolved Hide resolved
docs/resource-manager-generate-new-resource.md Outdated Show resolved Hide resolved
docs/resource-manager-partial-resource-generation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stephybun stephybun merged commit f8555d8 into main Jan 23, 2024
3 checks passed
@stephybun stephybun deleted the f/add-chaos-studio-resources branch January 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants