Use Object Storage URL Presigning for image create #87
Conversation
There was a problem hiding this comment.
Hi @kuzpactor,
Looks good to me, I just left a comment regarding the check for the empty Bucket that can be moved to Configure to get caught earlier in the build process, but this is not strictly linked to your PR so this can be addressed separately.
The change proposed may however slightly conflict with what you proposed in PR #84, won't it?
I would suggest merging one and then the other, and rebasing the latter on top of the current main. The order is not important in my opinion, so feel free to pick which one to merge first.
Thanks for the PR!
| @@ -139,10 +139,14 @@ func (p *PostProcessor) PostProcess(ctx context.Context, ui packersdk.Ui, artifa | |||
|
|
|||
| // As `bucket` option validate input here | |||
| if p.config.Bucket == "" { | |||
There was a problem hiding this comment.
I would suggest moving this to Configure maybe so it is handled before the build gets executed, since this is a configuration issue, it should be caught as early as possible to not waste user time.
Note: this is not directly related to this code, so this can be done in another patchset later.
This PR extends
presignUrl()function usage to include file-based sources to be uploaded on Object Storage.Closes #86