ignore setting job summary when oldstatus == newstatus

[drewbailey]

Ignoring setting job summary when job status has not changed.

firstPass was an invalid approach to prevent double job summary updates since applyUpsertJob calls setJobStatus twice, once during UpsertJob and once during UpertEval (atomic eval insertion).

When setting the job status, if oldstatus == newstatus, truly no-op instead of calculating the Jobsummary.

Before #9768, setJobStatus set oldStatus = "" which allowed the job summary to increment and decrement properly

https://github.com/hashicorp/nomad/blob/release-1.0.1/nomad/state/state_store.go#L4482-L4484

The current situation seems to be mostly related to test setup, before we could rely on the implementation to empty out the job status when it was created, but in reality the job comes in through the FSM without a job status set.

fixes #9875

[notnoop]

Good catch - lgtm.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.