consul/connect: enable configuring custom gateway task #9639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to configure the Task used for Connect gateways, similar to how sidecar Task can be configured. The implementation here simply re-uses the sidecar_task stanza, and now gets applied whether connect.sidecar_service or connect.gateway is the thing being defined. In retrospect, connect.sidecar_task could have been more generically named like connect.task to make it a little more re-usable. Closes #9474
shoenig
force-pushed
the
f-gateway-task
branch
from
dd6bca0 to
81d82dc
Compare
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
tgross
approved these changes
Dec 17, 2020
| ### Custom gateway task | ||
|
|
||
| The task created for the gateway can be configured manually using the | ||
| [`sidecar_task`][sidecar_task] stanza. |
There was a problem hiding this comment.
The connect parameters docs don't currently have any reference to the gateway. I feel like we need something explaining what happens if the sidecar_task is set if both sidecar_service and gateway blocks are used (and whether that's allowed at all!).
There was a problem hiding this comment.
Oh wow yea, it's totally missing gateway. Will add.
Co-authored-by: Tim Gross <[email protected]>
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
Co-authored-by: Tim Gross <[email protected]>
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
Co-authored-by: Tim Gross <[email protected]>
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to configure the Task used for connect gateways,
similar to how sidecar Task can be configured.
The implementation here simply re-uses the
sidecar_taskstanza,which now gets applied whether
connect.sidecar_serviceorconnect.gatewayis the thing being defined. In retrospect,connect.sidecar_taskmight have been more generically namedas something like
connect.task.Closes #9474