api: add field filters to /v1/{allocations,nodes} #9055
Conversation
Fixes #9017 The ?resources=true query parameter includes resources in the object stub listings. Specifically: - For `/v1/nodes?resources=true` both the `NodeResources` and `ReservedResources` field are included. - For `/v1/allocations?resources=true` the `AllocatedResources` field is included. The ?task_states=false query parameter removes TaskStates from /v1/allocations responses. (By default TaskStates are included.)
schmichael
force-pushed
the
f-9017-resources
branch
from
fcb15e7 to
276be86
Compare
schmichael
changed the title
| } | ||
|
|
||
| return false, nil | ||
| } |
There was a problem hiding this comment.
golf: seems like these two could be combined into something like parseBool(req *http.Request, param string)
There was a problem hiding this comment.
Pushed. Mind taking another peek? My old approach let a bug sneak in that should be fixed now.
There was a problem hiding this comment.
The bug being parseTaskStates would return false by default if the field was absent?
(LGTM)
In the past I've used a [closed] library for extracting url parameters by providing a schema, providing the name, type, and default value into a call to lib.Parse. It helped cleanup a lot of this url parameter boilerplate - might be worth trying to recreate it sometime.
| } | ||
|
|
||
| return false, nil | ||
| } |
There was a problem hiding this comment.
The bug being parseTaskStates would return false by default if the field was absent?
(LGTM)
In the past I've used a [closed] library for extracting url parameters by providing a schema, providing the name, type, and default value into a call to lib.Parse. It helped cleanup a lot of this url parameter boilerplate - might be worth trying to recreate it sometime.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #9017
The ?resources=true query parameter includes resources in the object stub listings. Specifically:
/v1/nodes?resources=trueboth theNodeResourcesandReservedResourcesfield are included./v1/allocations?resources=truetheAllocatedResourcesfield is included.The ?task_states=false query parameter removes TaskStates from
/v1/allocations responses. (By default TaskStates are included.)