Events/api #8947
Merged
Events/api #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbailey
force-pushed
the
event-stream
branch
from
1085ab3 to
45579be
Compare
drewbailey
force-pushed
the
events/api
branch
from
bc2d4e5 to
41e686b
Compare
drewbailey
force-pushed
the
event-stream
branch
from
45579be to
4b0ce2b
Compare
drewbailey
force-pushed
the
events/api
branch
3 times, most recently
from
fd9181c to
24aa54e
Compare
drewbailey
force-pushed
the
events/api
branch
2 times, most recently
from
05f6a87 to
b0cb956
Compare
drewbailey
force-pushed
the
event-stream
branch
from
4b0ce2b to
8f1ea1f
Compare
drewbailey
force-pushed
the
events/api
branch
3 times, most recently
from
be1a6fc to
00e7838
Compare
drewbailey
force-pushed
the
event-stream
branch
from
8f1ea1f to
0086c06
Compare
drewbailey
force-pushed
the
events/api
branch
from
00e7838 to
a357494
Compare
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
force-pushed
the
events/api
branch
from
c11371c to
31079ca
Compare
drewbailey
added a commit
that referenced
this pull request
Sep 29, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Sep 29, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 1, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 2, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 5, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 7, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 8, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 12, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 13, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
drewbailey
added a commit
that referenced
this pull request
Oct 14, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Oct 22, 2020
This Commit adds an /v1/events/stream endpoint to stream events from. The stream framer has been updated to include a SendFull method which does not fragment the data between multiple frames. This essentially treats the stream framer as a envelope to adhere to the stream framer interface in the UI. If the `encode` query parameter is omitted events will be streamed as newline delimted JSON.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
/v1/events/stream/endpoint and corresponding RPC for streaming events to a client.This endpoint introduces a new streaming mechanism for sending ndjson (http://ndjson.org/) for event streaming. This approach was chosen over our current stream framer since fragmenting event data in a framed envelope with offset wasn't necessary for the UI, and made consumption for regular consumers difficult.
The ndjson streamer will send events as new line delimited JSON and send an empty heartbeat(
{}) every 5 seconds.ACL checking is too restrictive right now (requires a management token), in a follow up PR it will be updated to check ACL policies against requested Topics.